summaryrefslogtreecommitdiffstats
path: root/docproc
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2018-09-11 15:41:34 +0200
committerHenning Baldersheim <balder@yahoo-inc.com>2018-09-11 15:41:34 +0200
commit06da5945a006c2e5462e72bf6bb41335cc55397a (patch)
tree07aba4de3b2a409823b2d6a73d5948ed9201eb51 /docproc
parentda218c2b4b43987d887e94cbd9326e676ad7085c (diff)
Avoid using deprecated API
Diffstat (limited to 'docproc')
-rw-r--r--docproc/src/main/java/com/yahoo/docproc/proxy/ProxyDocumentUpdate.java8
-rw-r--r--docproc/src/test/java/com/yahoo/docproc/ProcessingUpdateTestCase.java10
-rw-r--r--docproc/src/test/java/com/yahoo/docproc/proxy/SchemaMappingAndAccessesTest.java4
3 files changed, 15 insertions, 7 deletions
diff --git a/docproc/src/main/java/com/yahoo/docproc/proxy/ProxyDocumentUpdate.java b/docproc/src/main/java/com/yahoo/docproc/proxy/ProxyDocumentUpdate.java
index a0516a62bd9..39186555883 100644
--- a/docproc/src/main/java/com/yahoo/docproc/proxy/ProxyDocumentUpdate.java
+++ b/docproc/src/main/java/com/yahoo/docproc/proxy/ProxyDocumentUpdate.java
@@ -10,6 +10,7 @@ import com.yahoo.document.Field;
import com.yahoo.document.serialization.DocumentUpdateWriter;
import com.yahoo.document.update.FieldUpdate;
+import java.util.Collection;
import java.util.List;
import java.util.Map;
@@ -45,6 +46,7 @@ public class ProxyDocumentUpdate extends DocumentUpdate implements DocumentOpera
}
@Override
+ @SuppressWarnings( "deprecation" )
public FieldUpdate getFieldUpdate(int index) {
return docU.getFieldUpdate(index);
}
@@ -60,10 +62,14 @@ public class ProxyDocumentUpdate extends DocumentUpdate implements DocumentOpera
}
@Override
+ @SuppressWarnings( "deprecation" )
public List<FieldUpdate> getFieldUpdates() {
return docU.getFieldUpdates();
}
-
+ @Override
+ public Collection<FieldUpdate> getFieldUpdatesCollection() {
+ return docU.getFieldUpdatesCollection();
+ }
@Override
public DocumentId getId() {
return docU.getId();
diff --git a/docproc/src/test/java/com/yahoo/docproc/ProcessingUpdateTestCase.java b/docproc/src/test/java/com/yahoo/docproc/ProcessingUpdateTestCase.java
index 9a3a29e55b1..a89dbfcc782 100644
--- a/docproc/src/test/java/com/yahoo/docproc/ProcessingUpdateTestCase.java
+++ b/docproc/src/test/java/com/yahoo/docproc/ProcessingUpdateTestCase.java
@@ -37,8 +37,10 @@ public class ProcessingUpdateTestCase {
@Test
public void testProcessingUpdates() {
DocumentType articleType = new DocumentType("article");
- articleType.addField(new Field("body", DataType.STRING, true));
- articleType.addField(new Field("title", DataType.STRING, true));
+ Field bodyField = new Field("body", DataType.STRING, true);
+ Field titleField = new Field("title", DataType.STRING, true);
+ articleType.addField(bodyField);
+ articleType.addField(titleField);
dtm = new DocumentTypeManager();
dtm.registerDocumentType(articleType);
@@ -69,12 +71,12 @@ public class ProcessingUpdateTestCase {
assertEquals(new StringFieldValue("body blah blah blah "), first.getFieldValue("title"));
DocumentUpdate second = (DocumentUpdate) operations.get(1);
- FieldUpdate firstUpd = second.getFieldUpdate(0);
+ FieldUpdate firstUpd = second.getFieldUpdate(bodyField);
assertEquals(ValueUpdate.ValueUpdateClassID.ASSIGN, firstUpd.getValueUpdate(0).getValueUpdateClassID());
assertEquals(new StringFieldValue("this is the updated body of the article, blahdi blahdi blahdi"), firstUpd.getValueUpdate(0)
.getValue());
- FieldUpdate secondUpd = second.getFieldUpdate(1);
+ FieldUpdate secondUpd = second.getFieldUpdate(titleField);
assertEquals(ValueUpdate.ValueUpdateClassID.ASSIGN, secondUpd.getValueUpdate(0).getValueUpdateClassID());
assertEquals(new StringFieldValue("body blahdi blahdi blahdi "), secondUpd.getValueUpdate(0).getValue());
}
diff --git a/docproc/src/test/java/com/yahoo/docproc/proxy/SchemaMappingAndAccessesTest.java b/docproc/src/test/java/com/yahoo/docproc/proxy/SchemaMappingAndAccessesTest.java
index 05a03480173..c8ac2e31585 100644
--- a/docproc/src/test/java/com/yahoo/docproc/proxy/SchemaMappingAndAccessesTest.java
+++ b/docproc/src/test/java/com/yahoo/docproc/proxy/SchemaMappingAndAccessesTest.java
@@ -334,10 +334,10 @@ public class SchemaMappingAndAccessesTest {
fieldMap.put("a", "artist");
ProxyDocumentUpdate pup = new ProxyDocumentUpdate(dud, fieldMap);
pup.addFieldUpdate(assignSingle);
- assertEquals(pup.getFieldUpdates(), dud.getFieldUpdates());
+ assertEquals(pup.getFieldUpdatesCollection().toString(), dud.getFieldUpdatesCollection().toString());
assertEquals(pup.getDocumentType(), dud.getDocumentType());
assertEquals(pup.getFieldUpdate(new com.yahoo.document.Field("title")).size(), 1);
- assertEquals(pup.getFieldUpdate(0), dud.getFieldUpdate(0));
+ assertEquals(pup.getFieldUpdate(0), dud.getFieldUpdatesCollection().iterator().next());
assertEquals(pup.getFieldUpdate("title"), dud.getFieldUpdate("title"));
assertEquals(pup.getId(), dud.getId());
assertEquals(pup.getType(), dud.getType());