diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2024-02-19 20:31:01 +0000 |
---|---|---|
committer | Henning Baldersheim <balder@yahoo-inc.com> | 2024-02-19 20:31:39 +0000 |
commit | 4fb6eda621830f74204e9476b11ca7eb6a37b604 (patch) | |
tree | c9f1dfb2d76fe6381ab352b6807def2576bbf90d /document | |
parent | 91525f0e94bc150ef9e9879699c158ff93ddb628 (diff) |
Use auto, braced initialiser and noexcept
Diffstat (limited to 'document')
-rw-r--r-- | document/src/vespa/document/fieldvalue/boolfieldvalue.cpp | 2 | ||||
-rw-r--r-- | document/src/vespa/document/fieldvalue/fieldvalue.cpp | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/document/src/vespa/document/fieldvalue/boolfieldvalue.cpp b/document/src/vespa/document/fieldvalue/boolfieldvalue.cpp index 90b4b1711f1..b0b77fe2bf6 100644 --- a/document/src/vespa/document/fieldvalue/boolfieldvalue.cpp +++ b/document/src/vespa/document/fieldvalue/boolfieldvalue.cpp @@ -29,7 +29,7 @@ int BoolFieldValue::compare(const FieldValue&rhs) const { int diff = FieldValue::compare(rhs); if (diff != 0) return diff; - const BoolFieldValue &o = static_cast<const BoolFieldValue &>(rhs); + const auto &o = static_cast<const BoolFieldValue &>(rhs); return (_value == o._value) ? 0 : _value ? 1 : -1; } diff --git a/document/src/vespa/document/fieldvalue/fieldvalue.cpp b/document/src/vespa/document/fieldvalue/fieldvalue.cpp index d1939f09a1d..1fef35fec0c 100644 --- a/document/src/vespa/document/fieldvalue/fieldvalue.cpp +++ b/document/src/vespa/document/fieldvalue/fieldvalue.cpp @@ -185,7 +185,7 @@ FieldValue::UP FieldValue::onGetNestedFieldValue(PathRange nested) const { (void) nested; - return FieldValue::UP(); + return {}; } ModificationStatus @@ -221,7 +221,7 @@ namespace { class FieldValueFactory : public ComplexArrayT<FieldValue>::Factory { public: - FieldValueFactory(const DataType & dataType) : _dataType(&dataType) { } + explicit FieldValueFactory(const DataType & dataType) noexcept : _dataType(&dataType) { } FieldValue * create() override { return _dataType->createFieldValue().release(); } FieldValueFactory * clone() const override { return new FieldValueFactory(*this); } private: |