summaryrefslogtreecommitdiffstats
path: root/document
diff options
context:
space:
mode:
authorJon Bratseth <bratseth@gmail.com>2022-10-17 12:41:36 +0200
committerJon Bratseth <bratseth@gmail.com>2022-10-17 12:41:36 +0200
commit3ea887ac2bedf3b1c6e170cadf78d83a74bfc832 (patch)
treefb2c2c0d74aaff5f056c0cb8fe9d295fe3b4328d /document
parent11ca0ae7731223fb6d973a3cb694bcfd62d09281 (diff)
Restore legacy signature
Diffstat (limited to 'document')
-rw-r--r--document/src/main/java/com/yahoo/document/json/JsonReader.java9
-rw-r--r--document/src/test/java/com/yahoo/document/json/DocumentUpdateJsonSerializerTest.java2
-rw-r--r--document/src/test/java/com/yahoo/document/json/JsonReaderTestCase.java16
3 files changed, 16 insertions, 11 deletions
diff --git a/document/src/main/java/com/yahoo/document/json/JsonReader.java b/document/src/main/java/com/yahoo/document/json/JsonReader.java
index f90df5c117d..86023d52b63 100644
--- a/document/src/main/java/com/yahoo/document/json/JsonReader.java
+++ b/document/src/main/java/com/yahoo/document/json/JsonReader.java
@@ -52,7 +52,7 @@ public class JsonReader {
DocumentParser documentParser = new DocumentParser(parser);
return documentParser.parse(Optional.empty());
}
- java.lang.NoSuchMethodError: 'com.yahoo.document.DocumentOperation com.yahoo.document.json.JsonReader.readSingleDocument(com.yahoo.document.json.DocumentOperationType, java.lang.String)'
+
/**
* Reads a single operation. The operation is not expected to be part of an array.
*
@@ -60,7 +60,7 @@ public class JsonReader {
* @param docIdString document ID
* @return the parsed document operation
*/
- public ParsedDocumentOperation readSingleDocument(DocumentOperationType operationType, String docIdString) {
+ public ParsedDocumentOperation readOperation(DocumentOperationType operationType, String docIdString) {
DocumentId docId = new DocumentId(docIdString);
DocumentParseInfo documentParseInfo;
try {
@@ -78,6 +78,11 @@ public class JsonReader {
return operation;
}
+ @Deprecated // Use readOperation instead
+ public DocumentOperation readSingleDocument(DocumentOperationType operationType, String docIdString) {
+ return readOperation(operationType, docIdString).operation();
+ }
+
/** Returns the next document operation, or null if we have reached the end */
public DocumentOperation next() {
switch (state) {
diff --git a/document/src/test/java/com/yahoo/document/json/DocumentUpdateJsonSerializerTest.java b/document/src/test/java/com/yahoo/document/json/DocumentUpdateJsonSerializerTest.java
index 7bdb526bb1c..070ede480ac 100644
--- a/document/src/test/java/com/yahoo/document/json/DocumentUpdateJsonSerializerTest.java
+++ b/document/src/test/java/com/yahoo/document/json/DocumentUpdateJsonSerializerTest.java
@@ -96,7 +96,7 @@ public class DocumentUpdateJsonSerializerTest {
private static DocumentUpdate jsonToDocumentUpdate(String jsonDoc, String docId) {
final InputStream rawDoc = new ByteArrayInputStream(Utf8.toBytes(jsonDoc));
JsonReader reader = new JsonReader(types, rawDoc, parserFactory);
- return (DocumentUpdate) reader.readSingleDocument(DocumentOperationType.UPDATE, docId).operation();
+ return (DocumentUpdate) reader.readOperation(DocumentOperationType.UPDATE, docId).operation();
}
private static String documentUpdateToJson(DocumentUpdate update) {
diff --git a/document/src/test/java/com/yahoo/document/json/JsonReaderTestCase.java b/document/src/test/java/com/yahoo/document/json/JsonReaderTestCase.java
index 97422217857..bee2adb10a0 100644
--- a/document/src/test/java/com/yahoo/document/json/JsonReaderTestCase.java
+++ b/document/src/test/java/com/yahoo/document/json/JsonReaderTestCase.java
@@ -218,8 +218,8 @@ public class JsonReaderTestCase {
" 'nalle': 'bamse'",
" }",
"}"));
- DocumentPut put = (DocumentPut) r.readSingleDocument(DocumentOperationType.PUT,
- "id:unittest:smoke::doc1").operation();
+ DocumentPut put = (DocumentPut) r.readOperation(DocumentOperationType.PUT,
+ "id:unittest:smoke::doc1").operation();
smokeTestDoc(put.getDocument());
}
@@ -229,7 +229,7 @@ public class JsonReaderTestCase {
" 'fields': {",
" 'something': {",
" 'assign': 'orOther' }}}"));
- DocumentUpdate doc = (DocumentUpdate) r.readSingleDocument(DocumentOperationType.UPDATE, "id:unittest:smoke::whee").operation();
+ DocumentUpdate doc = (DocumentUpdate) r.readOperation(DocumentOperationType.UPDATE, "id:unittest:smoke::whee").operation();
FieldUpdate f = doc.getFieldUpdate("something");
assertEquals(1, f.size());
assertTrue(f.getValueUpdate(0) instanceof AssignValueUpdate);
@@ -241,7 +241,7 @@ public class JsonReaderTestCase {
" 'fields': {",
" 'int1': {",
" 'assign': null }}}"));
- DocumentUpdate doc = (DocumentUpdate) r.readSingleDocument(DocumentOperationType.UPDATE, "id:unittest:smoke::whee").operation();
+ DocumentUpdate doc = (DocumentUpdate) r.readOperation(DocumentOperationType.UPDATE, "id:unittest:smoke::whee").operation();
FieldUpdate f = doc.getFieldUpdate("int1");
assertEquals(1, f.size());
assertTrue(f.getValueUpdate(0) instanceof ClearValueUpdate);
@@ -1339,8 +1339,8 @@ public class JsonReaderTestCase {
" 'tensorfield': null",
" }",
"}"));
- DocumentPut put = (DocumentPut) r.readSingleDocument(DocumentOperationType.PUT,
- "id:unittest:testnull::doc1").operation();
+ DocumentPut put = (DocumentPut) r.readOperation(DocumentOperationType.PUT,
+ "id:unittest:testnull::doc1").operation();
Document doc = put.getDocument();
assertFieldValueNull(doc, "intfield");
assertFieldValueNull(doc, "stringfield");
@@ -1357,7 +1357,7 @@ public class JsonReaderTestCase {
" 'arrayfield': [ null ]",
" }",
"}"));
- r.readSingleDocument(DocumentOperationType.PUT, "id:unittest:testnull::doc1");
+ r.readOperation(DocumentOperationType.PUT, "id:unittest:testnull::doc1");
fail();
}
@@ -1639,7 +1639,7 @@ public class JsonReaderTestCase {
" 'fields': {",
" 'something': {",
" 'modify': {} }}}"));
- reader.readSingleDocument(DocumentOperationType.UPDATE, "id:unittest:smoke::doc1");
+ reader.readOperation(DocumentOperationType.UPDATE, "id:unittest:smoke::doc1");
fail("Expected exception");
}
catch (IllegalArgumentException e) {