diff options
author | Arne H. Juul <arnej@pvv.ntnu.no> | 2016-06-24 13:17:12 +0200 |
---|---|---|
committer | Arne H. Juul <arnej@pvv.ntnu.no> | 2016-07-02 14:47:30 +0200 |
commit | bb94e3b36cce9d88ad24927445a372db03ef2b36 (patch) | |
tree | a2b7c9cc016a331ff338a06b2050ab083b996900 /document | |
parent | 7d6f65499de1db475df68d53ecda67160635ab35 (diff) |
avoid "unused result" warnings
Diffstat (limited to 'document')
-rw-r--r-- | document/src/tests/documenttestcase.cpp | 38 | ||||
-rw-r--r-- | document/src/tests/documentupdatetestcase.cpp | 9 | ||||
-rw-r--r-- | document/src/tests/fieldpathupdatetestcase.cpp | 9 |
3 files changed, 39 insertions, 17 deletions
diff --git a/document/src/tests/documenttestcase.cpp b/document/src/tests/documenttestcase.cpp index 475cf64128e..6ea15c6a581 100644 --- a/document/src/tests/documenttestcase.cpp +++ b/document/src/tests/documenttestcase.cpp @@ -597,8 +597,9 @@ void DocumentTest::testReadSerializedFile() size_t len = lseek(fd,0,SEEK_END); ByteBuffer buf(len); lseek(fd,0,SEEK_SET); - read(fd, buf.getBuffer(), len); - + if (read(fd, buf.getBuffer(), len) != len) { + throw vespalib::Exception("read failed"); + } close(fd); Document doc(repo, buf); @@ -630,8 +631,9 @@ void DocumentTest::testReadSerializedFileCompressed() int len = lseek(fd,0,SEEK_END); ByteBuffer buf(len); lseek(fd,0,SEEK_SET); - read(fd, buf.getBuffer(), len); - + if (read(fd, buf.getBuffer(), len) != len) { + throw vespalib::Exception("read failed"); + } close(fd); Document doc(repo, buf); @@ -782,7 +784,9 @@ void DocumentTest::testReadSerializedAllVersions() int len = lseek(fd,0,SEEK_END); ByteBuffer buf(len); lseek(fd,0,SEEK_SET); - read(fd, buf.getBuffer(), len); + if (read(fd, buf.getBuffer(), len) != len) { + throw vespalib::Exception("read failed"); + } close(fd); Document doc(repo, buf); @@ -905,21 +909,27 @@ void DocumentTest::testGenerateSerializedFile() #define SERIALIZED_DIR "../../test/document/" int fd = open(SERIALIZED_DIR "/serializecpp.dat", O_WRONLY | O_TRUNC | O_CREAT, 0644); - write(fd, buf->getBuffer(), buf->getPos()); + if (write(fd, buf->getBuffer(), buf->getPos()) != buf->getPos()) { + throw vespalib::Exception("write failed"); + } close(fd); ByteBuffer hBuf(getSerializedSizeHeader(doc)); doc.serializeHeader(hBuf); fd = open(SERIALIZED_DIR "/serializecppsplit_header.dat", O_WRONLY | O_TRUNC | O_CREAT, 0644); - write(fd, hBuf.getBuffer(), hBuf.getPos()); + if (write(fd, hBuf.getBuffer(), hBuf.getPos()) != hBuf.getPos()) { + throw vespalib::Exception("write failed"); + } close(fd); ByteBuffer bBuf(getSerializedSizeBody(doc)); doc.serializeBody(bBuf); fd = open(SERIALIZED_DIR "/serializecppsplit_body.dat", O_WRONLY | O_TRUNC | O_CREAT, 0644); - write(fd, bBuf.getBuffer(), bBuf.getPos()); + if (write(fd, bBuf.getBuffer(), bBuf.getPos()) != bBuf.getPos()) { + throw vespalib::Exception("write failed"); + } close(fd); @@ -933,7 +943,9 @@ void DocumentTest::testGenerateSerializedFile() fd = open(SERIALIZED_DIR "/serializecpp-lz4-level9.dat", O_WRONLY | O_TRUNC | O_CREAT, 0644); - write(fd, lz4buf.getBufferAtPos(), lz4buf.getRemaining()); + if (write(fd, lz4buf.getBufferAtPos(), lz4buf.getRemaining()) != lz4buf.getRemaining()) { + throw vespalib::Exception("write failed"); + } close(fd); } void DocumentTest::testGetURIFromSerialized() @@ -1300,7 +1312,9 @@ DocumentTest::testUnknownEntries() int len = lseek(fd,0,SEEK_END); ByteBuffer buf(len); lseek(fd,0,SEEK_SET); - read(fd, buf.getBuffer(), len); + if (read(fd, buf.getBuffer(), len) != len) { + throw vespalib::Exception("read failed"); + } close(fd); DocumenttypesConfigBuilderHelper builder; @@ -1347,7 +1361,9 @@ void DocumentTest::testAnnotationDeserialization() int len = lseek(fd,0,SEEK_END); ByteBuffer buf(len); lseek(fd,0,SEEK_SET); - read(fd, buf.getBuffer(), len); + if (read(fd, buf.getBuffer(), len) != len) { + throw vespalib::Exception("read failed"); + } close(fd); Document doc(repo, buf); diff --git a/document/src/tests/documentupdatetestcase.cpp b/document/src/tests/documentupdatetestcase.cpp index be619b0f35e..b2358f18937 100644 --- a/document/src/tests/documentupdatetestcase.cpp +++ b/document/src/tests/documentupdatetestcase.cpp @@ -556,8 +556,9 @@ void DocumentUpdateTest::testReadSerializedFile() int len = lseek(fd,0,SEEK_END); ByteBuffer buf(len); lseek(fd,0,SEEK_SET); - read(fd, buf.getBuffer(), len); - + if (read(fd, buf.getBuffer(), len) != len) { + throw vespalib::Exception("read failed"); + } close(fd); DocumentUpdate::UP updp(DocumentUpdate::create42(repo, buf)); @@ -648,7 +649,9 @@ void DocumentUpdateTest::testGenerateSerializedFile() int fd = open("data/serializeupdatecpp.dat", O_WRONLY | O_TRUNC | O_CREAT, 0644); - write(fd, buf->getBuffer(), buf->getPos()); + if (write(fd, buf->getBuffer(), buf->getPos()) != buf->getPos()) { + throw vespalib::Exception("read failed"); + } close(fd); } diff --git a/document/src/tests/fieldpathupdatetestcase.cpp b/document/src/tests/fieldpathupdatetestcase.cpp index ec999d0dfe9..e261a7798bf 100644 --- a/document/src/tests/fieldpathupdatetestcase.cpp +++ b/document/src/tests/fieldpathupdatetestcase.cpp @@ -1278,8 +1278,9 @@ FieldPathUpdateTestCase::testReadSerializedFile() int len = lseek(fd,0,SEEK_END); ByteBuffer buf(len); lseek(fd,0,SEEK_SET); - read(fd, buf.getBuffer(), len); - + if (read(fd, buf.getBuffer(), len) != len) { + throw vespalib::Exception("read failed"); + } close(fd); DocumentUpdate::UP updp(DocumentUpdate::createHEAD(repo, buf)); @@ -1303,7 +1304,9 @@ FieldPathUpdateTestCase::testGenerateSerializedFile() int fd = open("data/serialize-fieldpathupdate-cpp.dat", O_WRONLY | O_TRUNC | O_CREAT, 0644); - write(fd, buf->getBuffer(), buf->getPos()); + if (write(fd, buf->getBuffer(), buf->getPos()) != buf->getPos()) { + throw vespalib::Exception("write failed"); + } close(fd); } |