summaryrefslogtreecommitdiffstats
path: root/document
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2019-08-15 20:33:36 +0200
committerHenning Baldersheim <balder@yahoo-inc.com>2019-08-15 20:33:36 +0200
commitc5dd20f345de738acd500a91f5c400198f6c3ef6 (patch)
treefb2e57127c6122cdc217698d30a96c995235f335 /document
parent7626ef4e275cc4f8ad81e5e31a56aad2f7c62593 (diff)
Follow up from review comments.
Diffstat (limited to 'document')
-rw-r--r--document/src/main/java/com/yahoo/document/select/rule/ArithmeticNode.java1
-rw-r--r--document/src/main/java/com/yahoo/document/select/rule/IdNode.java11
2 files changed, 1 insertions, 11 deletions
diff --git a/document/src/main/java/com/yahoo/document/select/rule/ArithmeticNode.java b/document/src/main/java/com/yahoo/document/select/rule/ArithmeticNode.java
index c14957c94a4..2297c5228d4 100644
--- a/document/src/main/java/com/yahoo/document/select/rule/ArithmeticNode.java
+++ b/document/src/main/java/com/yahoo/document/select/rule/ArithmeticNode.java
@@ -5,6 +5,7 @@ import com.yahoo.document.BucketIdFactory;
import com.yahoo.document.datatypes.NumericFieldValue;
import com.yahoo.document.select.BucketSet;
import com.yahoo.document.select.Context;
+import com.yahoo.document.select.Result;
import com.yahoo.document.select.Visitor;
import java.util.List;
diff --git a/document/src/main/java/com/yahoo/document/select/rule/IdNode.java b/document/src/main/java/com/yahoo/document/select/rule/IdNode.java
index f0f8815d467..214d55a4bd8 100644
--- a/document/src/main/java/com/yahoo/document/select/rule/IdNode.java
+++ b/document/src/main/java/com/yahoo/document/select/rule/IdNode.java
@@ -39,14 +39,6 @@ public class IdNode implements ExpressionNode {
return this;
}
- public short getWidthBits() {
- return widthBits;
- }
-
- public short getDivisionBits() {
- return divisionBits;
- }
-
@Override
public BucketSet getBucketSet(BucketIdFactory factory) {
return null;
@@ -81,12 +73,9 @@ public class IdNode implements ExpressionNode {
return id.getScheme().getDocType();
}
throw new IllegalStateException("Document id doesn't have doc type.");
- } else if (field.equalsIgnoreCase("order")) {
- // TODO Remove from grammar on VESPA 8
} else {
throw new IllegalStateException("Identifier field '" + field + "' is not supported.");
}
- return null;
}
@Override