public scalars should be final

* make it so
* also, implement hashCode()

1 files changed, 8 insertions, 4 deletions

diff --git a/document/src/main/java/com/yahoo/document/select/OrderingSpecification.java b/document/src/main/java/com/yahoo/document/select/OrderingSpecification.java
index 3f5a7a58733..774aa0e4e27 100644
--- a/document/src/main/java/com/yahoo/document/select/OrderingSpecification.java
+++ b/document/src/main/java/com/yahoo/document/select/OrderingSpecification.java
@@ -5,10 +5,10 @@ public class OrderingSpecification {
     public static int ASCENDING = 0;
     public static int DESCENDING = 1;
 
-    public int order;
-    public long orderingStart;
-    public short widthBits;
-    public short divisionBits;
+    public final int order;
+    public final long orderingStart;
+    public final short widthBits;
+    public final short divisionBits;
 
     public OrderingSpecification() {
         this(ASCENDING, (long)0, (short)0, (short)0);
@@ -37,6 +37,10 @@ public class OrderingSpecification {
         return (order == o.order && orderingStart == o.orderingStart && widthBits == o.widthBits && divisionBits == o.divisionBits);
     }
 
+    public int hashCode() {
+        return order + widthBits*9901 + divisionBits*9973 + 2*(int)orderingStart;
+    }
+
     public String toString() {
         return "O: " + order + " S:" + orderingStart + " W:" + widthBits + " D:" + divisionBits;
     }