diff options
author | Tor Brede Vekterli <vekterli@yahoo-inc.com> | 2016-11-15 16:46:06 +0100 |
---|---|---|
committer | Tor Brede Vekterli <vekterli@yahoo-inc.com> | 2016-11-15 16:46:06 +0100 |
commit | 98d6d76bf1059655a1c7adf4b4b911c0b397e510 (patch) | |
tree | ce76121cc9377be93d64821c208740d7d1a4542e /documentapi | |
parent | e6af0a305f8d5c4312b733b79215b1040dfd704e (diff) |
Add missing DocumentProtocol error name printing
Diffstat (limited to 'documentapi')
2 files changed, 14 insertions, 0 deletions
diff --git a/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/DocumentProtocol.java b/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/DocumentProtocol.java index e4988d3c8b8..0247d7e1e7c 100755 --- a/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/DocumentProtocol.java +++ b/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/DocumentProtocol.java @@ -412,6 +412,8 @@ public class DocumentProtocol implements Protocol { switch (code) { case ERROR_MESSAGE_IGNORED: return "MESSAGE_IGNORED"; + case ERROR_POLICY_FAILURE: + return "POLICY_FAILURE"; case ERROR_DOCUMENT_NOT_FOUND: return "DOCUMENT_NOT_FOUND"; case ERROR_DOCUMENT_EXISTS: @@ -438,6 +440,8 @@ public class DocumentProtocol implements Protocol { return "PROCESSING_FAILURE"; case ERROR_TIMESTAMP_EXIST: return "TIMESTAMP_EXIST"; + case ERROR_STALE_TIMESTAMP: + return "STALE_TIMESTAMP"; case ERROR_NODE_NOT_READY: return "NODE_NOT_READY"; case ERROR_WRONG_DISTRIBUTION: diff --git a/documentapi/src/test/java/com/yahoo/documentapi/messagebus/protocol/test/ErrorCodesTest.java b/documentapi/src/test/java/com/yahoo/documentapi/messagebus/protocol/test/ErrorCodesTest.java index 16a6347d2ad..dbafd4e2f87 100644 --- a/documentapi/src/test/java/com/yahoo/documentapi/messagebus/protocol/test/ErrorCodesTest.java +++ b/documentapi/src/test/java/com/yahoo/documentapi/messagebus/protocol/test/ErrorCodesTest.java @@ -83,4 +83,14 @@ public class ErrorCodesTest { codes.put("ERROR_STALE_TIMESTAMP", DocumentProtocol.ERROR_STALE_TIMESTAMP); codes.put("ERROR_SUSPENDED", DocumentProtocol.ERROR_SUSPENDED); } + + @Test + public void getErrorNameIsDefinedForAllKnownProtocolErrorCodes() { + final NamedErrorCodes codes = new NamedErrorCodes(); + enumerateAllDocumentProtocolErrorCodes(codes); + codes.nameAndCode.entrySet().forEach(kv -> { + // Error names are not prefixed by "ERROR_" unlike their enum counterparts. + assertEquals(kv.getKey(), "ERROR_" + DocumentProtocol.getErrorName(kv.getValue())); + }); + } } |