diff options
| author | Tor Brede Vekterli <vekterli@vespa.ai> | 2024-02-27 15:30:29 +0000 |
|---|---|---|
| committer | Tor Brede Vekterli <vekterli@vespa.ai> | 2024-02-27 15:30:29 +0000 |
| commit | 427d620bd43caedbb259a956423682e3e93f5a82 (patch) | |
| tree | 9453f902c384016cd4534a92afc15da4b5017833 /documentapi | |
| parent | ce4669f88b5b5993b64c017401c92044cdb1e49d (diff) | |
Add Vespa 9 deprecation comment for lazy deserialization
Since the lazy deserialization captures the entire message payload,
it's not independent of the protocol version used and it's therefore
not safe to set or use it from any other protocol than the legacy
version.
Diffstat (limited to 'documentapi')
3 files changed, 6 insertions, 3 deletions
diff --git a/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/GetDocumentReply.java b/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/GetDocumentReply.java index 0690168f298..1704bd3827e 100755 --- a/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/GetDocumentReply.java +++ b/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/GetDocumentReply.java @@ -11,9 +11,10 @@ import java.nio.ByteBuffer; */ public class GetDocumentReply extends DocumentAcceptedReply { - private DocumentDeserializer buffer = null; private Document document = null; private long lastModified = 0; + // TODO Vespa 9: remove. Inherently tied to legacy protocol version. + private DocumentDeserializer buffer = null; private LazyDecoder decoder = null; /** diff --git a/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/PutDocumentMessage.java b/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/PutDocumentMessage.java index 04a55a6fd16..7ce25011ec1 100755 --- a/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/PutDocumentMessage.java +++ b/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/PutDocumentMessage.java @@ -14,9 +14,10 @@ import java.util.Arrays; */ public class PutDocumentMessage extends TestAndSetMessage { - private DocumentDeserializer buffer = null; private DocumentPut put = null; private long time = 0; + // TODO Vespa 9: remove. Inherently tied to legacy protocol version. + private DocumentDeserializer buffer = null; private LazyDecoder decoder = null; /** diff --git a/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/UpdateDocumentMessage.java b/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/UpdateDocumentMessage.java index d395353209f..3fb14664628 100755 --- a/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/UpdateDocumentMessage.java +++ b/documentapi/src/main/java/com/yahoo/documentapi/messagebus/protocol/UpdateDocumentMessage.java @@ -13,10 +13,11 @@ import java.util.Arrays; */ public class UpdateDocumentMessage extends TestAndSetMessage { - private DocumentDeserializer buffer = null; private DocumentUpdate update = null; private long oldTime = 0; private long newTime = 0; + // TODO Vespa 9: remove. Inherently tied to legacy protocol version. + private DocumentDeserializer buffer = null; private LazyDecoder decoder = null; /** |