Let successful RemoveReponse and UpdateRespone have NOT_FOUND outcome

2 files changed, 10 insertions, 2 deletions

diff --git a/documentapi/src/main/java/com/yahoo/documentapi/RemoveResponse.java b/documentapi/src/main/java/com/yahoo/documentapi/RemoveResponse.java
index 502588a3d5f..2a7c6f45d95 100644
--- a/documentapi/src/main/java/com/yahoo/documentapi/RemoveResponse.java
+++ b/documentapi/src/main/java/com/yahoo/documentapi/RemoveResponse.java
@@ -12,7 +12,7 @@ public class RemoveResponse extends Response {
     private final boolean wasFound;
 
     public RemoveResponse(long requestId, boolean wasFound) {
-        super(requestId);
+        super(requestId, null, wasFound ? Outcome.SUCCESS : Outcome.NOT_FOUND);
         this.wasFound = wasFound;
     }
 
@@ -21,6 +21,10 @@ public class RemoveResponse extends Response {
     }
 
     @Override
+    // TODO: fix this when/if NOT_FOUND is no longer a success.
+    public boolean isSuccess() { return super.isSuccess() || outcome() == Outcome.NOT_FOUND; }
+
+    @Override
     public int hashCode() {
         return super.hashCode() + Boolean.valueOf(wasFound).hashCode();
     }
diff --git a/documentapi/src/main/java/com/yahoo/documentapi/UpdateResponse.java b/documentapi/src/main/java/com/yahoo/documentapi/UpdateResponse.java
index 96bf58c1e64..aca34a92a30 100644
--- a/documentapi/src/main/java/com/yahoo/documentapi/UpdateResponse.java
+++ b/documentapi/src/main/java/com/yahoo/documentapi/UpdateResponse.java
@@ -12,7 +12,7 @@ public class UpdateResponse extends Response {
     private final boolean wasFound;
 
     public UpdateResponse(long requestId, boolean wasFound) {
-        super(requestId);
+        super(requestId, null, wasFound ? Outcome.SUCCESS : Outcome.NOT_FOUND);
         this.wasFound = wasFound;
     }
 
@@ -21,6 +21,10 @@ public class UpdateResponse extends Response {
     }
 
     @Override
+    // TODO: fix this when/if NOT_FOUND is no longer a success.
+    public boolean isSuccess() { return super.isSuccess() || outcome() == Outcome.NOT_FOUND; }
+
+    @Override
     public int hashCode() {
         return super.hashCode() + Boolean.valueOf(wasFound).hashCode();
     }