summaryrefslogtreecommitdiffstats
path: root/documentapi
diff options
context:
space:
mode:
authorTor Egge <Tor.Egge@oath.com>2017-10-20 09:40:49 +0000
committerTor Egge <Tor.Egge@oath.com>2017-10-20 09:40:49 +0000
commit7e18bbfba09eab60283b51eaeefaf94e4879788b (patch)
tree45570a9dbfd2b80e0ad58f135cc385a6371e8592 /documentapi
parentcc37711ebe8d5584159c5b38be25de5be9a5b9f1 (diff)
Add bucket space to GetBucketListReply.
Diffstat (limited to 'documentapi')
-rw-r--r--documentapi/src/tests/messages/messages50test.cpp3
-rw-r--r--documentapi/src/vespa/documentapi/messagebus/messages/getbucketlistmessage.cpp2
-rw-r--r--documentapi/src/vespa/documentapi/messagebus/messages/getbucketlistreply.cpp3
-rw-r--r--documentapi/src/vespa/documentapi/messagebus/messages/getbucketlistreply.h5
-rw-r--r--documentapi/src/vespa/documentapi/messagebus/routablefactories50.cpp2
5 files changed, 9 insertions, 6 deletions
diff --git a/documentapi/src/tests/messages/messages50test.cpp b/documentapi/src/tests/messages/messages50test.cpp
index a3627522562..20e21518d13 100644
--- a/documentapi/src/tests/messages/messages50test.cpp
+++ b/documentapi/src/tests/messages/messages50test.cpp
@@ -12,6 +12,7 @@
using document::DataType;
using document::DocumentTypeRepo;
using document::test::makeDocumentBucket;
+using document::BucketSpace;
///////////////////////////////////////////////////////////////////////////////
//
@@ -1112,7 +1113,7 @@ Messages50Test::testWrongDistributionReply()
bool
Messages50Test::testGetBucketListReply()
{
- GetBucketListReply reply;
+ GetBucketListReply reply(BucketSpace::placeHolder());
reply.getBuckets().push_back(GetBucketListReply::BucketInfo(document::BucketId(16, 123), "foo"));
reply.getBuckets().push_back(GetBucketListReply::BucketInfo(document::BucketId(17, 1123), "bar"));
reply.getBuckets().push_back(GetBucketListReply::BucketInfo(document::BucketId(18, 11123), "zoink"));
diff --git a/documentapi/src/vespa/documentapi/messagebus/messages/getbucketlistmessage.cpp b/documentapi/src/vespa/documentapi/messagebus/messages/getbucketlistmessage.cpp
index 49e8e048db5..974135972f6 100644
--- a/documentapi/src/vespa/documentapi/messagebus/messages/getbucketlistmessage.cpp
+++ b/documentapi/src/vespa/documentapi/messagebus/messages/getbucketlistmessage.cpp
@@ -16,7 +16,7 @@ GetBucketListMessage::GetBucketListMessage(const document::Bucket &bucket) :
DocumentReply::UP
GetBucketListMessage::doCreateReply() const
{
- return DocumentReply::UP(new GetBucketListReply());
+ return DocumentReply::UP(new GetBucketListReply(_bucket.getBucketSpace()));
}
uint32_t
diff --git a/documentapi/src/vespa/documentapi/messagebus/messages/getbucketlistreply.cpp b/documentapi/src/vespa/documentapi/messagebus/messages/getbucketlistreply.cpp
index e144158e0ef..e9f66ed1f2f 100644
--- a/documentapi/src/vespa/documentapi/messagebus/messages/getbucketlistreply.cpp
+++ b/documentapi/src/vespa/documentapi/messagebus/messages/getbucketlistreply.cpp
@@ -23,8 +23,9 @@ GetBucketListReply::BucketInfo::operator==(const GetBucketListReply::BucketInfo
return _bucket == rhs._bucket && _bucketInformation == rhs._bucketInformation;
}
-GetBucketListReply::GetBucketListReply() :
+GetBucketListReply::GetBucketListReply(document::BucketSpace bucketSpace) :
DocumentReply(DocumentProtocol::REPLY_GETBUCKETLIST),
+ _bucketSpace(bucketSpace),
_buckets()
{
// empty
diff --git a/documentapi/src/vespa/documentapi/messagebus/messages/getbucketlistreply.h b/documentapi/src/vespa/documentapi/messagebus/messages/getbucketlistreply.h
index 3ded7f7d08b..3c6a2a25bfc 100644
--- a/documentapi/src/vespa/documentapi/messagebus/messages/getbucketlistreply.h
+++ b/documentapi/src/vespa/documentapi/messagebus/messages/getbucketlistreply.h
@@ -2,7 +2,7 @@
#pragma once
#include "documentreply.h"
-#include <vespa/document/bucket/bucketid.h>
+#include <vespa/document/bucket/bucket.h>
namespace documentapi {
@@ -20,13 +20,14 @@ public:
};
private:
+ document::BucketSpace _bucketSpace;
std::vector<BucketInfo> _buckets;
public:
/**
* Constructs a new reply with no content.
*/
- GetBucketListReply();
+ GetBucketListReply(document::BucketSpace bucketSpace);
/**
* Returns the bucket state contained in this.
diff --git a/documentapi/src/vespa/documentapi/messagebus/routablefactories50.cpp b/documentapi/src/vespa/documentapi/messagebus/routablefactories50.cpp
index 028db2f02c0..f9e244dfad6 100644
--- a/documentapi/src/vespa/documentapi/messagebus/routablefactories50.cpp
+++ b/documentapi/src/vespa/documentapi/messagebus/routablefactories50.cpp
@@ -424,7 +424,7 @@ RoutableFactories50::GetBucketListMessageFactory::doEncode(const DocumentMessage
DocumentReply::UP
RoutableFactories50::GetBucketListReplyFactory::doDecode(document::ByteBuffer &buf) const
{
- DocumentReply::UP ret(new GetBucketListReply());
+ DocumentReply::UP ret(new GetBucketListReply(BucketSpace::placeHolder()));
GetBucketListReply &reply = static_cast<GetBucketListReply&>(*ret);
int32_t len = decodeInt(buf);