summaryrefslogtreecommitdiffstats
path: root/documentapi
diff options
context:
space:
mode:
authorvalerijf <valerijf@yahoo-inc.com>2017-05-12 09:28:06 +0200
committervalerijf <valerijf@yahoo-inc.com>2017-05-12 09:40:38 +0200
commit09be694323fbe1955c345e183d807d7c60e80c51 (patch)
tree71dd6c36587e0d256b6c57ec05a7faf17abbaaba /documentapi
parentbd6bb3b7518e3da3869d1f45741c0cd86795308a (diff)
Code review fixes
Diffstat (limited to 'documentapi')
-rw-r--r--documentapi/src/main/java/com/yahoo/documentapi/messagebus/MessageBusAsyncSession.java8
-rwxr-xr-xdocumentapi/src/main/java/com/yahoo/documentapi/messagebus/MessageBusSyncSession.java6
2 files changed, 2 insertions, 12 deletions
diff --git a/documentapi/src/main/java/com/yahoo/documentapi/messagebus/MessageBusAsyncSession.java b/documentapi/src/main/java/com/yahoo/documentapi/messagebus/MessageBusAsyncSession.java
index 845a04490b5..9f20ca78d6e 100644
--- a/documentapi/src/main/java/com/yahoo/documentapi/messagebus/MessageBusAsyncSession.java
+++ b/documentapi/src/main/java/com/yahoo/documentapi/messagebus/MessageBusAsyncSession.java
@@ -198,14 +198,6 @@ public class MessageBusAsyncSession implements MessageBusSession, AsyncSession {
return errors.toString();
}
- public static Set<Integer> getErrorCodes(Reply reply) {
- Set<Integer> errorCodes = new HashSet<>();
- for (int i = 0; i < reply.getNumErrors(); ++i) {
- errorCodes.add(reply.getError(i).getCode());
- }
- return errorCodes;
- }
-
private static Result.ResultType messageBusErrorToResultType(int messageBusError) {
switch (messageBusError) {
case ErrorCode.SEND_QUEUE_FULL: return Result.ResultType.TRANSIENT_ERROR;
diff --git a/documentapi/src/main/java/com/yahoo/documentapi/messagebus/MessageBusSyncSession.java b/documentapi/src/main/java/com/yahoo/documentapi/messagebus/MessageBusSyncSession.java
index 106791491f9..47eeb12b250 100755
--- a/documentapi/src/main/java/com/yahoo/documentapi/messagebus/MessageBusSyncSession.java
+++ b/documentapi/src/main/java/com/yahoo/documentapi/messagebus/MessageBusSyncSession.java
@@ -167,8 +167,7 @@ public class MessageBusSyncSession implements MessageBusSession, SyncSession, Re
msg.setPriority(pri);
Reply reply = syncSend(msg);
if (reply.hasErrors()) {
- throw new DocumentAccessException(MessageBusAsyncSession.getErrorMessage(reply),
- MessageBusAsyncSession.getErrorCodes(reply));
+ throw new DocumentAccessException(MessageBusAsyncSession.getErrorMessage(reply), reply.getErrorCodes());
}
if (reply.getType() != DocumentProtocol.REPLY_UPDATEDOCUMENT) {
throw new DocumentAccessException("Received unknown response: " + reply);
@@ -218,8 +217,7 @@ public class MessageBusSyncSession implements MessageBusSession, SyncSession, Re
private void syncSendPutDocumentMessage(PutDocumentMessage putDocumentMessage) {
Reply reply = syncSend(putDocumentMessage);
if (reply.hasErrors()) {
- throw new DocumentAccessException(MessageBusAsyncSession.getErrorMessage(reply),
- MessageBusAsyncSession.getErrorCodes(reply));
+ throw new DocumentAccessException(MessageBusAsyncSession.getErrorMessage(reply), reply.getErrorCodes());
}
}
}