Merge pull request #9853 from vespa-engine/havardpe/remove-error-value-constant

remove error_value constant

1 files changed, 4 insertions, 10 deletions

diff --git a/eval/src/tests/eval/function/function_test.cpp b/eval/src/tests/eval/function/function_test.cpp
index 6c3839b6cc9..c2561a86d6f 100644
--- a/eval/src/tests/eval/function/function_test.cpp
+++ b/eval/src/tests/eval/function/function_test.cpp
@@ -14,20 +14,14 @@ std::vector<vespalib::string> params({"x", "y", "z", "w"});
 
 double as_number(const Function &f) {
     auto number = as<Number>(f.root());
-    if (number) {
-        return number->value();
-    } else {
-        return error_value;
-    }
+    ASSERT_TRUE(number);
+    return number->value();
 }
 
 vespalib::string as_string(const Function &f) {
     auto string = as<String>(f.root());
-    if (string) {
-        return string->value();
-    } else {
-        return "<error>";
-    }
+    ASSERT_TRUE(string);
+    return string->value();
 }
 
 struct OperatorLayer {