diff options
author | bjormel <bjormel@yahooinc.com> | 2023-10-26 13:59:28 +0000 |
---|---|---|
committer | bjormel <bjormel@yahooinc.com> | 2023-10-26 13:59:28 +0000 |
commit | 567be9a1f6353cec41c23bfd1fcd46b4b2a4d2d7 (patch) | |
tree | 4664a743e166a5e11aee7b9acd70ad8ee2617612 /eval/src/vespa/eval/eval/value_builder_factory.h | |
parent | e9058b555d4dfea2f6c872d9a677e8678b569569 (diff) | |
parent | bce3b8e926bf9da880172acbe1ba4b12d5e026d6 (diff) |
Merge branch 'master' into bjormel/aws-main-controllerbjormel/aws-main-controller
Diffstat (limited to 'eval/src/vespa/eval/eval/value_builder_factory.h')
-rw-r--r-- | eval/src/vespa/eval/eval/value_builder_factory.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/eval/src/vespa/eval/eval/value_builder_factory.h b/eval/src/vespa/eval/eval/value_builder_factory.h index dd8181fc4a8..8f4a10b7281 100644 --- a/eval/src/vespa/eval/eval/value_builder_factory.h +++ b/eval/src/vespa/eval/eval/value_builder_factory.h @@ -1,4 +1,4 @@ -// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root. +// Copyright Vespa.ai. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root. #pragma once @@ -11,7 +11,7 @@ namespace vespalib::eval { * downcasting to actual builder with specialized cell type. **/ struct ValueBuilderBase { - virtual ~ValueBuilderBase() {} + virtual ~ValueBuilderBase() = default; }; /** @@ -59,7 +59,7 @@ private: { assert(check_cell_type<T>(type.cell_type())); auto base = create_value_builder_base(type, transient, num_mapped_dims_in, subspace_size_in, expected_subspaces); - ValueBuilder<T> *builder = static_cast<ValueBuilder<T>*>(base.get()); + auto *builder = static_cast<ValueBuilder<T>*>(base.get()); base.release(); return std::unique_ptr<ValueBuilder<T>>(builder); } @@ -82,7 +82,7 @@ public: return create_value_builder<T>(type, false, type.count_mapped_dimensions(), type.dense_subspace_size(), 1); } std::unique_ptr<Value> copy(const Value &value) const; - virtual ~ValueBuilderFactory() {} + virtual ~ValueBuilderFactory() = default; protected: virtual std::unique_ptr<ValueBuilderBase> create_value_builder_base(const ValueType &type, bool transient, size_t num_mapped_dims_in, size_t subspace_size_in, size_t expected_subspaces) const = 0; |