aboutsummaryrefslogtreecommitdiffstats
path: root/eval
diff options
context:
space:
mode:
authorArne Juul <arnej@verizonmedia.com>2021-02-05 14:30:47 +0000
committerArne Juul <arnej@verizonmedia.com>2021-02-05 14:30:47 +0000
commite83cad153e534f39670d9fdd5bd4d58975c4dad0 (patch)
tree3216ebf5dd5d44b0ee1a25878777cc555fd7da0d /eval
parent491ae609b62a4e61bedac86bf2306b1f28c9cc54 (diff)
cosmetic fixes after review
Diffstat (limited to 'eval')
-rw-r--r--eval/src/vespa/eval/instruction/sparse_merge_function.cpp12
1 files changed, 2 insertions, 10 deletions
diff --git a/eval/src/vespa/eval/instruction/sparse_merge_function.cpp b/eval/src/vespa/eval/instruction/sparse_merge_function.cpp
index fe2fca36f07..9a07016e232 100644
--- a/eval/src/vespa/eval/instruction/sparse_merge_function.cpp
+++ b/eval/src/vespa/eval/instruction/sparse_merge_function.cpp
@@ -135,8 +135,6 @@ const Value& my_fast_sparse_merge(const FastAddrMap &a_map, const FastAddrMap &b
});
}
return result;
-
-
}
template <typename CT, bool single_dim, typename Fun>
@@ -178,7 +176,6 @@ SparseMergeFunction::SparseMergeFunction(const tensor_function::Merge &original)
InterpretedFunction::Instruction
SparseMergeFunction::compile_self(const ValueBuilderFactory &factory, Stash &stash) const
{
- assert(result_type() == ValueType::join(lhs().result_type(), rhs().result_type()));
const auto &param = stash.create<SparseMergeParam>(result_type(), function(), factory);
size_t num_dims = result_type().count_mapped_dimensions();
auto op = typify_invoke<3,MyTypify,SelectSparseMergeOp>(result_type().cell_type(),
@@ -194,13 +191,8 @@ SparseMergeFunction::compatible_types(const ValueType &res, const ValueType &lhs
&& (lhs.count_mapped_dimensions() > 0)
&& (lhs.dense_subspace_size() == 1))
{
- assert(rhs.dense_subspace_size() == lhs.dense_subspace_size());
- assert(rhs.count_mapped_dimensions() == lhs.count_mapped_dimensions());
-
- assert(res.cell_type() == lhs.cell_type());
- assert(res.dense_subspace_size() == lhs.dense_subspace_size());
- assert(res.count_mapped_dimensions() == lhs.count_mapped_dimensions());
-
+ assert(res == lhs);
+ assert(res == rhs);
return true;
}
return false;