summaryrefslogtreecommitdiffstats
path: root/eval
diff options
context:
space:
mode:
authorArne Juul <arnej@verizonmedia.com>2020-10-14 13:11:43 +0000
committerArne Juul <arnej@verizonmedia.com>2020-10-14 13:11:43 +0000
commit8956a4e0299342eea6660c098cafc8497d8ceae6 (patch)
treecc3c3f83cf21d146ac8773c6430e651618ccaefc /eval
parentc45266c12f0a7b8c67a74f535e01057561505564 (diff)
minor cosmetic fixes
Diffstat (limited to 'eval')
-rw-r--r--eval/src/vespa/eval/eval/tensor_spec.cpp3
-rw-r--r--eval/src/vespa/eval/eval/test/value_compare.cpp3
-rw-r--r--eval/src/vespa/eval/eval/test/value_compare.h3
3 files changed, 4 insertions, 5 deletions
diff --git a/eval/src/vespa/eval/eval/tensor_spec.cpp b/eval/src/vespa/eval/eval/tensor_spec.cpp
index 9f4751fb3b7..98bc09217c1 100644
--- a/eval/src/vespa/eval/eval/tensor_spec.cpp
+++ b/eval/src/vespa/eval/eval/tensor_spec.cpp
@@ -116,8 +116,7 @@ TensorSpec::from_slime(const slime::Inspector &tensor)
TensorSpec
TensorSpec::from_value(const eval::Value &value)
{
- auto tensor = dynamic_cast<const vespalib::eval::Tensor *>(&value);
- if (tensor) {
+ if (auto tensor = dynamic_cast<const vespalib::eval::Tensor *>(&value)) {
return tensor->engine().to_spec(value);
} else {
return spec_from_value(value);
diff --git a/eval/src/vespa/eval/eval/test/value_compare.cpp b/eval/src/vespa/eval/eval/test/value_compare.cpp
index 361926d1a7e..ff6a4e72ebc 100644
--- a/eval/src/vespa/eval/eval/test/value_compare.cpp
+++ b/eval/src/vespa/eval/eval/test/value_compare.cpp
@@ -14,8 +14,7 @@ bool operator==(const Value &lhs, const Value &rhs)
std::ostream &operator<<(std::ostream &out, const Value &value)
{
- out << TensorSpec::from_value(value);
- return out;
+ return out << TensorSpec::from_value(value);
}
} // namespace vespalib::eval
diff --git a/eval/src/vespa/eval/eval/test/value_compare.h b/eval/src/vespa/eval/eval/test/value_compare.h
index d3978309564..f514cec8da7 100644
--- a/eval/src/vespa/eval/eval/test/value_compare.h
+++ b/eval/src/vespa/eval/eval/test/value_compare.h
@@ -7,7 +7,8 @@
namespace vespalib::eval {
bool operator==(const Value &lhs, const Value &rhs);
-std::ostream &operator<<(std::ostream &out, const Value &tensor);
+
+std::ostream &operator<<(std::ostream &out, const Value &value);
}