summaryrefslogtreecommitdiffstats
path: root/eval
diff options
context:
space:
mode:
authorArne Juul <arnej@verizonmedia.com>2020-11-30 12:56:41 +0000
committerArne Juul <arnej@verizonmedia.com>2020-11-30 12:56:41 +0000
commit6cfdc395d29bbb399c3010c0d60a3141f8d4d915 (patch)
tree049601e1117fedbe283ab66789afe8cbb16ccaae /eval
parent7a9047804a199fb3472a6c31127cf0368ecb173e (diff)
remove comparison with SimpleTensor results
Diffstat (limited to 'eval')
-rw-r--r--eval/src/tests/instruction/generic_concat/generic_concat_test.cpp21
1 files changed, 0 insertions, 21 deletions
diff --git a/eval/src/tests/instruction/generic_concat/generic_concat_test.cpp b/eval/src/tests/instruction/generic_concat/generic_concat_test.cpp
index c59d9783648..b5ff2ec3b48 100644
--- a/eval/src/tests/instruction/generic_concat/generic_concat_test.cpp
+++ b/eval/src/tests/instruction/generic_concat/generic_concat_test.cpp
@@ -3,8 +3,6 @@
#include <vespa/eval/eval/simple_value.h>
#include <vespa/eval/eval/fast_value.h>
#include <vespa/eval/eval/value_codec.h>
-#include <vespa/eval/eval/simple_tensor.h>
-#include <vespa/eval/eval/simple_tensor_engine.h>
#include <vespa/eval/eval/value_codec.h>
#include <vespa/eval/instruction/generic_concat.h>
#include <vespa/eval/eval/interpreted_function.h>
@@ -58,13 +56,6 @@ std::vector<Layout> concat_layouts = {
{y(2),x({"a","b"})}, {y(3),z({"c","d"})}
};
-TensorSpec perform_simpletensor_concat(const TensorSpec &a, const TensorSpec &b, const std::string &dimension) {
- auto lhs = SimpleTensor::create(a);
- auto rhs = SimpleTensor::create(b);
- auto out = SimpleTensor::concat(*lhs, *rhs, dimension);
- return SimpleTensorEngine::ref().to_spec(*out);
-}
-
TensorSpec perform_generic_concat(const TensorSpec &a, const TensorSpec &b,
const std::string &concat_dim, const ValueBuilderFactory &factory)
{
@@ -76,18 +67,6 @@ TensorSpec perform_generic_concat(const TensorSpec &a, const TensorSpec &b,
return spec_from_value(single.eval(std::vector<Value::CREF>({*lhs,*rhs})));
}
-TEST(GenericConcatTest, generic_reference_concat_works) {
- ASSERT_TRUE((concat_layouts.size() % 2) == 0);
- for (size_t i = 0; i < concat_layouts.size(); i += 2) {
- const TensorSpec lhs = spec(concat_layouts[i], N());
- const TensorSpec rhs = spec(concat_layouts[i + 1], Div16(N()));
- SCOPED_TRACE(fmt("\n===\nin LHS: %s\nin RHS: %s\n===\n", lhs.to_string().c_str(), rhs.to_string().c_str()));
- auto actual = ReferenceOperations::concat(lhs, rhs, "y");
- auto expect = perform_simpletensor_concat(lhs, rhs, "y");
- EXPECT_EQ(actual, expect);
- }
-}
-
void test_generic_concat_with(const ValueBuilderFactory &factory) {
ASSERT_TRUE((concat_layouts.size() % 2) == 0);
for (size_t i = 0; i < concat_layouts.size(); i += 2) {