test add_subspace robustness for FastValue

1 files changed, 55 insertions, 0 deletions

diff --git a/eval/src/tests/eval/fast_value/fast_value_test.cpp b/eval/src/tests/eval/fast_value/fast_value_test.cpp
index 19ddcb3d788..7b06f02a569 100644
--- a/eval/src/tests/eval/fast_value/fast_value_test.cpp
+++ b/eval/src/tests/eval/fast_value/fast_value_test.cpp
@@ -1,6 +1,8 @@
 // Copyright Verizon Media. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
 
 #include <vespa/eval/eval/fast_value.hpp>
+#include <vespa/eval/eval/fast_value.h>
+#include <vespa/eval/eval/value_codec.h>
 #include <vespa/vespalib/gtest/gtest.h>
 
 using namespace vespalib;
@@ -56,4 +58,57 @@ TEST(FastCellsTest, add_cells_works) {
     EXPECT_EQ(*cells.get(5), 6.0);
 }
 
+using SA = std::vector<vespalib::stringref>;
+
+TEST(FastValueTest, add_subspace_robustness) {
+    auto factory = FastValueBuilderFactory::get();
+    ValueType type = ValueType::from_spec("tensor(x[2])");
+    auto builder = factory.create_value_builder<double>(type);
+    auto subspace = builder->add_subspace({});
+    subspace[0] = 17.0;
+    subspace[1] = 666;
+    auto other = builder->add_subspace({});
+    other[1] = 42.0;
+    auto value = builder->build(std::move(builder));
+    auto actual = spec_from_value(*value);
+    auto expected = TensorSpec("tensor(x[2])").
+                    add({{"x", 0}}, 17.0).
+                    add({{"x", 1}}, 42.0);
+    EXPECT_EQ(actual, expected);    
+
+    type = ValueType::from_spec("tensor(x{})");
+    builder = factory.create_value_builder<double>(type);
+    subspace = builder->add_subspace(SA{"foo"});
+    subspace[0] = 17.0;
+    subspace = builder->add_subspace(SA{"bar"});
+    subspace[0] = 18.0;
+    other = builder->add_subspace(SA{"foo"});
+    other[0] = 42.0;
+    value = builder->build(std::move(builder));
+    actual = spec_from_value(*value);
+    expected = TensorSpec("tensor(x{})").
+               add({{"x", "bar"}}, 18.0).
+               add({{"x", "foo"}}, 42.0);
+    EXPECT_EQ(actual, expected);    
+
+    type = ValueType::from_spec("tensor(x{},y[2])");
+    builder = factory.create_value_builder<double>(type);
+    subspace = builder->add_subspace(SA{"foo"});
+    subspace[0] = 17.0;
+    subspace[1] = 666;
+    subspace = builder->add_subspace(SA{"bar"});
+    subspace[0] = 18.0;
+    subspace[1] = 19.0;
+    other = builder->add_subspace(SA{"foo"});
+    other[1] = 42.0;
+    value = builder->build(std::move(builder));
+    actual = spec_from_value(*value);
+    expected = TensorSpec("tensor(x{},y[2])").
+               add({{"x", "foo"}, {"y", 0}}, 17.0).
+               add({{"x", "bar"}, {"y", 0}}, 18.0).
+               add({{"x", "bar"}, {"y", 1}}, 19.0).
+               add({{"x", "foo"}, {"y", 1}}, 42.0);
+    EXPECT_EQ(actual, expected);    
+}
+
 GTEST_MAIN_RUN_ALL_TESTS()