summaryrefslogtreecommitdiffstats
path: root/eval
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2020-03-20 10:03:04 +0000
committerHenning Baldersheim <balder@yahoo-inc.com>2020-03-20 10:03:04 +0000
commit27dc368c19cd5b442f1e434ed6eef15d9b777453 (patch)
tree92e2cfb2c46d6004b0334f7ee31004c5a5fc3056 /eval
parentcdbec799d9babdfc9b69d65c0ce052728c01b449 (diff)
Reinline
Diffstat (limited to 'eval')
-rw-r--r--eval/src/vespa/eval/tensor/sparse/direct_sparse_tensor_builder.cpp12
-rw-r--r--eval/src/vespa/eval/tensor/sparse/direct_sparse_tensor_builder.h13
2 files changed, 9 insertions, 16 deletions
diff --git a/eval/src/vespa/eval/tensor/sparse/direct_sparse_tensor_builder.cpp b/eval/src/vespa/eval/tensor/sparse/direct_sparse_tensor_builder.cpp
index 4a28b54d201..c47521e702d 100644
--- a/eval/src/vespa/eval/tensor/sparse/direct_sparse_tensor_builder.cpp
+++ b/eval/src/vespa/eval/tensor/sparse/direct_sparse_tensor_builder.cpp
@@ -43,18 +43,6 @@ DirectSparseTensorBuilder::build() {
return std::make_unique<SparseTensor>(std::move(_type), std::move(_cells), std::move(_stash));
}
-void
-DirectSparseTensorBuilder::insertCell(SparseTensorAddressRef address, double value) {
- // This address should not already exist and a new cell should be inserted.
- insertCell(address, value, [](double, double) -> double { HDR_ABORT("should not be reached"); });
-}
-
-void
-DirectSparseTensorBuilder::insertCell(SparseTensorAddressBuilder &address, double value) {
- // This address should not already exist and a new cell should be inserted.
- insertCell(address.getAddressRef(), value, [](double, double) -> double { HDR_ABORT("should not be reached"); });
-}
-
void DirectSparseTensorBuilder::reserve(uint32_t estimatedCells) {
_cells.resize(estimatedCells*2);
}
diff --git a/eval/src/vespa/eval/tensor/sparse/direct_sparse_tensor_builder.h b/eval/src/vespa/eval/tensor/sparse/direct_sparse_tensor_builder.h
index f9182a199be..bcb22c0761d 100644
--- a/eval/src/vespa/eval/tensor/sparse/direct_sparse_tensor_builder.h
+++ b/eval/src/vespa/eval/tensor/sparse/direct_sparse_tensor_builder.h
@@ -45,15 +45,20 @@ public:
}
}
- void insertCell(SparseTensorAddressRef address, double value);
+ void insertCell(SparseTensorAddressRef address, double value) {
+ // This address should not already exist and a new cell should be inserted.
+ insertCell(address, value, [](double, double) -> double { HDR_ABORT("should not be reached"); });
+ }
template <class Function>
- void insertCell(SparseTensorAddressBuilder &address, double value, Function &&func)
- {
+ void insertCell(SparseTensorAddressBuilder &address, double value, Function &&func) {
insertCell(address.getAddressRef(), value, func);
}
- void insertCell(SparseTensorAddressBuilder &address, double value);
+ void insertCell(SparseTensorAddressBuilder &address, double value) {
+ // This address should not already exist and a new cell should be inserted.
+ insertCell(address.getAddressRef(), value, [](double, double) -> double { HDR_ABORT("should not be reached"); });
+ }
eval::ValueType &fast_type() { return _type; }
Cells &cells() { return _cells; }