summaryrefslogtreecommitdiffstats
path: root/eval
diff options
context:
space:
mode:
authorTor Egge <Tor.Egge@broadpark.no>2020-12-04 10:34:23 +0100
committerTor Egge <Tor.Egge@broadpark.no>2020-12-04 10:34:23 +0100
commit5c66bb9199a0c8e02282f5d3a38a08e3741918cf (patch)
tree860ceffda85d63299559b9d07ddee0a1b62a3311 /eval
parent555200c6f53a4ddb579181cac50a950c5647d854 (diff)
Eliminate inlining warnings.
Diffstat (limited to 'eval')
-rw-r--r--eval/src/tests/eval/function/function_test.cpp3
-rw-r--r--eval/src/vespa/eval/eval/make_tensor_function.cpp3
-rw-r--r--eval/src/vespa/eval/eval/param_usage.cpp6
-rw-r--r--eval/src/vespa/eval/eval/test/tensor_model.hpp3
4 files changed, 15 insertions, 0 deletions
diff --git a/eval/src/tests/eval/function/function_test.cpp b/eval/src/tests/eval/function/function_test.cpp
index 598d9c251a6..3dbc2e1aed2 100644
--- a/eval/src/tests/eval/function/function_test.cpp
+++ b/eval/src/tests/eval/function/function_test.cpp
@@ -418,6 +418,7 @@ struct MyTraverser : public NodeTraverser {
std::vector<std::pair<bool, const nodes::Node &> > history;
explicit MyTraverser(size_t open_true_cnt_in)
: open_true_cnt(open_true_cnt_in), history() {}
+ ~MyTraverser() override;
virtual bool open(const nodes::Node &node) override {
history.emplace_back(true, node);
if (open_true_cnt == 0) {
@@ -448,6 +449,8 @@ struct MyTraverser : public NodeTraverser {
}
};
+MyTraverser::~MyTraverser() = default;
+
size_t verify_traversal(size_t open_true_cnt, const vespalib::string &expression) {
auto function = Function::parse(expression);
if (!EXPECT_TRUE(!function->has_error())) {
diff --git a/eval/src/vespa/eval/eval/make_tensor_function.cpp b/eval/src/vespa/eval/eval/make_tensor_function.cpp
index 3f8c8b8861b..9ee42f164de 100644
--- a/eval/src/vespa/eval/eval/make_tensor_function.cpp
+++ b/eval/src/vespa/eval/eval/make_tensor_function.cpp
@@ -26,6 +26,7 @@ struct TensorFunctionBuilder : public NodeVisitor, public NodeTraverser {
TensorFunctionBuilder(Stash &stash_in, const ValueBuilderFactory &factory_in, const NodeTypes &types_in)
: stash(stash_in), factory(factory_in), types(types_in), stack() {}
+ ~TensorFunctionBuilder() override;
//-------------------------------------------------------------------------
@@ -354,6 +355,8 @@ struct TensorFunctionBuilder : public NodeVisitor, public NodeTraverser {
void close(const Node &node) override { node.accept(*this); }
};
+TensorFunctionBuilder::~TensorFunctionBuilder() = default;
+
} // namespace vespalib::eval::<unnamed>
const TensorFunction &make_tensor_function(const ValueBuilderFactory &factory, const nodes::Node &root, const NodeTypes &types, Stash &stash) {
diff --git a/eval/src/vespa/eval/eval/param_usage.cpp b/eval/src/vespa/eval/eval/param_usage.cpp
index b43c0c01833..1f28c6eaa51 100644
--- a/eval/src/vespa/eval/eval/param_usage.cpp
+++ b/eval/src/vespa/eval/eval/param_usage.cpp
@@ -18,6 +18,7 @@ struct CountUsage : NodeTraverser {
double p;
std::vector<double> result;
CountUsage(size_t num_params) : p(1.0), result(num_params, 0.0) {}
+ ~CountUsage() override;
bool open(const Node &node) override {
if (auto if_node = as<If>(node)) {
double my_p = p;
@@ -38,11 +39,14 @@ struct CountUsage : NodeTraverser {
}
};
+CountUsage::~CountUsage() = default;
+
//-----------------------------------------------------------------------------
struct CheckUsage : NodeTraverser {
std::vector<double> result;
CheckUsage(size_t num_params) : result(num_params, 0.0) {}
+ ~CheckUsage() override;
void merge(const std::vector<double> &true_result,
const std::vector<double> &false_result,
double p_true)
@@ -72,6 +76,8 @@ struct CheckUsage : NodeTraverser {
}
};
+CheckUsage::~CheckUsage() = default;
+
//-----------------------------------------------------------------------------
} // namespace vespalib::eval::<unnamed>
diff --git a/eval/src/vespa/eval/eval/test/tensor_model.hpp b/eval/src/vespa/eval/eval/test/tensor_model.hpp
index 2f8c0d68946..02e0b51742d 100644
--- a/eval/src/vespa/eval/eval/test/tensor_model.hpp
+++ b/eval/src/vespa/eval/eval/test/tensor_model.hpp
@@ -77,12 +77,15 @@ struct Seq : Sequence {
std::vector<double> seq;
Seq() : seq() {}
Seq(const std::vector<double> &seq_in) : seq(seq_in) {}
+ ~Seq() override;
double operator[](size_t i) const override {
ASSERT_LESS(i, seq.size());
return seq[i];
}
};
+Seq::~Seq() = default;
+
// Random access bit mask
struct Mask {
virtual bool operator[](size_t i) const = 0;