summaryrefslogtreecommitdiffstats
path: root/filedistribution
diff options
context:
space:
mode:
authorHarald Musum <musum@yahoo-inc.com>2017-11-23 21:55:41 +0100
committerGitHub <noreply@github.com>2017-11-23 21:55:41 +0100
commit480f78725c6b59861105fe138686120ea0a60851 (patch)
tree207468e06caa1c4240c9599616cf7b203f293130 /filedistribution
parente603b021de8b94ba2a70799b7f70da439bcc42b5 (diff)
Revert "Hmusum/choose new connection if file reference not found"
Diffstat (limited to 'filedistribution')
-rw-r--r--filedistribution/src/main/java/com/yahoo/vespa/filedistribution/FileReferenceDownloader.java14
1 files changed, 5 insertions, 9 deletions
diff --git a/filedistribution/src/main/java/com/yahoo/vespa/filedistribution/FileReferenceDownloader.java b/filedistribution/src/main/java/com/yahoo/vespa/filedistribution/FileReferenceDownloader.java
index cd07591c00c..08595662f36 100644
--- a/filedistribution/src/main/java/com/yahoo/vespa/filedistribution/FileReferenceDownloader.java
+++ b/filedistribution/src/main/java/com/yahoo/vespa/filedistribution/FileReferenceDownloader.java
@@ -54,7 +54,6 @@ class FileReferenceDownloader {
private final FileReceiver fileReceiver;
FileReferenceDownloader(File downloadDirectory, ConnectionPool connectionPool, Duration timeout) {
- log.log(LogLevel.DEBUG, "FileReferenceDownloader connection pool:\n" + connectionPool);
this.connectionPool = connectionPool;
this.downloadTimeout = timeout;
readFromQueueExecutor.submit(this::readFromQueue);
@@ -108,7 +107,8 @@ class FileReferenceDownloader {
Thread.sleep(10);
} catch (InterruptedException e) { /* ignore for now */}
} else {
- log.log(LogLevel.INFO, "Will download file reference '" + fileReferenceDownload.fileReference().value() + "'");
+ log.log(LogLevel.INFO, "Polling queue, found file reference '" +
+ fileReferenceDownload.fileReference().value() + "' to download");
downloadExecutor.submit(() -> startDownload(fileReferenceDownload.fileReference(), downloadTimeout, fileReferenceDownload));
}
} while (true);
@@ -133,16 +133,12 @@ class FileReferenceDownloader {
return true;
} else {
log.log(LogLevel.INFO, "File reference '" + fileReference.value() + "' not found for " + connection.getAddress());
- connectionPool.setNewCurrentConnection();
return false;
}
} else {
- log.log(LogLevel.WARNING, "Request failed. Req: " + request + "\nSpec: " + connection.getAddress() +
- ", error code: " + request.errorCode());
- if (request.isError() && request.errorCode() == ErrorCode.CONNECTION || request.errorCode() == ErrorCode.TIMEOUT) {
- log.log(LogLevel.WARNING, "Setting error for connection " + connection.getAddress());
- connectionPool.setError(connection, request.errorCode());
- }
+ log.log(LogLevel.WARNING, "Request failed. Req: " + request + "\nSpec: " + connection.getAddress());
+ if (request.isError() && request.errorCode() == ErrorCode.CONNECTION)
+ connection.setError(request.errorCode());
return false;
}
}