summaryrefslogtreecommitdiffstats
path: root/hosted-api
diff options
context:
space:
mode:
authorJon Marius Venstad <jvenstad@yahoo-inc.com>2019-05-14 15:09:56 +0200
committerJon Marius Venstad <jvenstad@yahoo-inc.com>2019-05-14 15:10:06 +0200
commitf43949f67157e349cef3051adf9cf0ead6e0b2fc (patch)
tree25afb6ade1719af6e052043078362cc77aa250d9 /hosted-api
parentdbe747d9d70d99cba32136be6c186d678d5c24ac (diff)
Delete unused code
Diffstat (limited to 'hosted-api')
-rw-r--r--hosted-api/src/main/java/ai/vespa/hosted/api/ControllerHttpClient.java14
-rw-r--r--hosted-api/src/main/java/ai/vespa/hosted/api/Deployment.java44
2 files changed, 6 insertions, 52 deletions
diff --git a/hosted-api/src/main/java/ai/vespa/hosted/api/ControllerHttpClient.java b/hosted-api/src/main/java/ai/vespa/hosted/api/ControllerHttpClient.java
index 63de0fd8373..5a38154b7c0 100644
--- a/hosted-api/src/main/java/ai/vespa/hosted/api/ControllerHttpClient.java
+++ b/hosted-api/src/main/java/ai/vespa/hosted/api/ControllerHttpClient.java
@@ -211,20 +211,8 @@ public abstract class ControllerHttpClient {
private static String metaToJson(Deployment deployment) {
Slime slime = new Slime();
Cursor rootObject = slime.setObject();
-
- if (deployment.repository().isPresent()) {
- Cursor revisionObject = rootObject.setObject("sourceRevision");
- deployment.repository().ifPresent(repository -> revisionObject.setString("repository", repository));
- deployment.branch().ifPresent(branch -> revisionObject.setString("branch", branch));
- deployment.commit().ifPresent(commit -> revisionObject.setString("commit", commit));
- deployment.build().ifPresent(build -> rootObject.setLong("buildNumber", build));
- }
-
deployment.version().ifPresent(version -> rootObject.setString("vespaVersion", version));
-
- if (deployment.ignoreValidationErrors()) rootObject.setBool("ignoreValidationErrors", true);
rootObject.setBool("deployDirectly", true);
-
return toJson(slime);
}
@@ -244,7 +232,7 @@ public abstract class ControllerHttpClient {
private static MultiPartStreamer toDataStream(Deployment deployment) {
MultiPartStreamer streamer = new MultiPartStreamer();
streamer.addJson("deployOptions", metaToJson(deployment));
- deployment.applicationZip().ifPresent(zip -> streamer.addFile("applicationZip", zip));
+ streamer.addFile("applicationZip", deployment.applicationZip());
return streamer;
}
diff --git a/hosted-api/src/main/java/ai/vespa/hosted/api/Deployment.java b/hosted-api/src/main/java/ai/vespa/hosted/api/Deployment.java
index 8f981ca5f05..e745f555847 100644
--- a/hosted-api/src/main/java/ai/vespa/hosted/api/Deployment.java
+++ b/hosted-api/src/main/java/ai/vespa/hosted/api/Deployment.java
@@ -9,59 +9,25 @@ import java.util.OptionalLong;
*/
public class Deployment {
- // Deployment options
private final Optional<String> version;
- private final boolean ignoreValidationErrors;
+ private final Path applicationZip;
- // Provide an application package ...
- private final Optional<Path> applicationZip;
-
- // ... or reference a previously submitted one.
- private final Optional<String> repository;
- private final Optional<String> branch;
- private final Optional<String> commit;
- private final OptionalLong build;
-
- private Deployment(Optional<String> version, boolean ignoreValidationErrors, Optional<Path> applicationZip,
- Optional<String> repository, Optional<String> branch, Optional<String> commit, OptionalLong build) {
+ private Deployment(Optional<String> version, Path applicationZip) {
this.version = version;
- this.ignoreValidationErrors = ignoreValidationErrors;
this.applicationZip = applicationZip;
- this.repository = repository;
- this.branch = branch;
- this.commit = commit;
- this.build = build;
}
-
/** Returns a deployment which will use the provided application package. */
public static Deployment ofPackage(Path applicationZipFile) {
- return new Deployment(Optional.empty(), false, Optional.of(applicationZipFile),
- Optional.empty(), Optional.empty(), Optional.empty(), OptionalLong.empty());
- }
-
- /** Returns a deployment which will use the previously submitted package with the given reference. */
- public static Deployment ofReference(String repository, String branch, String commit, long build) {
- return new Deployment(Optional.empty(), false, Optional.empty(),
- Optional.of(repository), Optional.of(branch), Optional.of(commit), OptionalLong.of(build));
+ return new Deployment(Optional.empty(), applicationZipFile);
}
/** Returns a copy of this which will have the specified Vespa version on its nodes. */
public Deployment atVersion(String vespaVersion) {
- return new Deployment(Optional.of(vespaVersion), ignoreValidationErrors, applicationZip, repository, branch, commit, build);
- }
-
- /** Returns a copy of this which will additionally ignore validation errors upon deployment. */
- public Deployment ignoringValidationErrors() {
- return new Deployment(version, true, applicationZip, repository, branch, commit, build);
+ return new Deployment(Optional.of(vespaVersion), applicationZip);
}
public Optional<String> version() { return version; }
- public boolean ignoreValidationErrors() { return ignoreValidationErrors; }
- public Optional<Path> applicationZip() { return applicationZip; }
- public Optional<String> repository() { return repository; }
- public Optional<String> branch() { return branch; }
- public Optional<String> commit() { return commit; }
- public OptionalLong build() { return build; }
+ public Path applicationZip() { return applicationZip; }
}