diff options
author | Bjørn Christian Seime <bjorncs@verizonmedia.com> | 2021-01-14 13:41:08 +0100 |
---|---|---|
committer | Bjørn Christian Seime <bjorncs@verizonmedia.com> | 2021-01-14 13:49:44 +0100 |
commit | 2985d11c35f0e5eb6f176c1ef758ada7fc910e60 (patch) | |
tree | 93b90ffdd4351b3a808cbb7fb42ac579d187fa23 /http-utils | |
parent | ca91a0771b5b4fffd6e883dc2868a1cce2bfb9d5 (diff) |
Use a single, shared TlsContext instance
The configuration is based on environment variables, which are effectively fixed through the life of the JVM instance.
This simplifaction removes the need for complex cleanup logic based on manual reference counting and weak references.
Diffstat (limited to 'http-utils')
-rw-r--r-- | http-utils/src/main/java/ai/vespa/util/http/VespaAsyncHttpClientBuilder.java | 2 | ||||
-rw-r--r-- | http-utils/src/main/java/ai/vespa/util/http/VespaHttpClientBuilder.java | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/http-utils/src/main/java/ai/vespa/util/http/VespaAsyncHttpClientBuilder.java b/http-utils/src/main/java/ai/vespa/util/http/VespaAsyncHttpClientBuilder.java index 6c53ea0dc69..f5457e17e96 100644 --- a/http-utils/src/main/java/ai/vespa/util/http/VespaAsyncHttpClientBuilder.java +++ b/http-utils/src/main/java/ai/vespa/util/http/VespaAsyncHttpClientBuilder.java @@ -45,7 +45,7 @@ public class VespaAsyncHttpClientBuilder { public static HttpAsyncClientBuilder create(AsyncConnectionManagerFactory factory) { HttpAsyncClientBuilder clientBuilder = HttpAsyncClientBuilder.create(); - TlsContext vespaTlsContext = TransportSecurityUtils.createTlsContext().orElse(null); + TlsContext vespaTlsContext = TransportSecurityUtils.getSystemTlsContext().orElse(null); TlsStrategy tlsStrategy; if (vespaTlsContext != null) { SSLParameters vespaTlsParameters = vespaTlsContext.parameters(); diff --git a/http-utils/src/main/java/ai/vespa/util/http/VespaHttpClientBuilder.java b/http-utils/src/main/java/ai/vespa/util/http/VespaHttpClientBuilder.java index a408b0d79ae..741570e950b 100644 --- a/http-utils/src/main/java/ai/vespa/util/http/VespaHttpClientBuilder.java +++ b/http-utils/src/main/java/ai/vespa/util/http/VespaHttpClientBuilder.java @@ -78,7 +78,7 @@ public class VespaHttpClientBuilder { } private static void addSslSocketFactory(HttpClientBuilder builder, ConnectionManagerFactory connectionManagerFactory) { - TransportSecurityUtils.createTlsContext() + TransportSecurityUtils.getSystemTlsContext() .ifPresent(tlsContext -> { log.log(Level.FINE, "Adding ssl socket factory to client"); SSLConnectionSocketFactory socketFactory = createSslSocketFactory(tlsContext); |