summaryrefslogtreecommitdiffstats
path: root/indexinglanguage
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2022-09-21 06:56:26 +0200
committerGitHub <noreply@github.com>2022-09-21 06:56:26 +0200
commita42b44c9a6680929cb1f260571526ac101ccdba8 (patch)
tree64c5d2699fb0a1713c5cea06e40d03575de9dd8b /indexinglanguage
parentb01f2aa1cf4ad37dd0d30ceceef7493da7d7bb1b (diff)
Revert "Revert "Short circuit boolean expressions""
Diffstat (limited to 'indexinglanguage')
-rw-r--r--indexinglanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/ArithmeticExpression.java20
1 files changed, 7 insertions, 13 deletions
diff --git a/indexinglanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/ArithmeticExpression.java b/indexinglanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/ArithmeticExpression.java
index fa82c4d88ee..e4bc2dae965 100644
--- a/indexinglanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/ArithmeticExpression.java
+++ b/indexinglanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/ArithmeticExpression.java
@@ -166,19 +166,13 @@ public final class ArithmeticExpression extends CompositeExpression {
}
BigDecimal lhsVal = asBigDecimal((NumericFieldValue)lhs);
BigDecimal rhsVal = asBigDecimal((NumericFieldValue)rhs);
- switch (op) {
- case ADD:
- return createFieldValue(lhs, rhs, lhsVal.add(rhsVal));
- case SUB:
- return createFieldValue(lhs, rhs, lhsVal.subtract(rhsVal));
- case MUL:
- return createFieldValue(lhs, rhs, lhsVal.multiply(rhsVal));
- case DIV:
- return createFieldValue(lhs, rhs, lhsVal.divide(rhsVal, MathContext.DECIMAL64));
- case MOD:
- return createFieldValue(lhs, rhs, lhsVal.remainder(rhsVal));
- }
- throw new IllegalStateException("Unsupported operation: " + op);
+ return switch (op) {
+ case ADD -> createFieldValue(lhs, rhs, lhsVal.add(rhsVal));
+ case SUB -> createFieldValue(lhs, rhs, lhsVal.subtract(rhsVal));
+ case MUL -> createFieldValue(lhs, rhs, lhsVal.multiply(rhsVal));
+ case DIV -> createFieldValue(lhs, rhs, lhsVal.divide(rhsVal, MathContext.DECIMAL64));
+ case MOD -> createFieldValue(lhs, rhs, lhsVal.remainder(rhsVal));
+ };
}
private FieldValue createFieldValue(FieldValue lhs, FieldValue rhs, BigDecimal val) {