diff options
author | Morten Tokle <mortent@yahooinc.com> | 2023-09-21 13:32:02 +0200 |
---|---|---|
committer | Morten Tokle <mortent@yahooinc.com> | 2023-09-21 13:32:02 +0200 |
commit | 1f63858ebac9b11c6b452165f44f86c58b947610 (patch) | |
tree | e7613a2e2a3e34b8c8057e6d82ff6730a559a20a /jdisc-security-filters/src | |
parent | d355ae3e36bf0de7bac1f697d8e0dd0feea61bbe (diff) |
Improve test
Diffstat (limited to 'jdisc-security-filters/src')
-rw-r--r-- | jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/cloud/CloudTokenDataPlaneFilterTest.java | 29 |
1 files changed, 21 insertions, 8 deletions
diff --git a/jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/cloud/CloudTokenDataPlaneFilterTest.java b/jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/cloud/CloudTokenDataPlaneFilterTest.java index c34740e58a3..2ff6209fd06 100644 --- a/jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/cloud/CloudTokenDataPlaneFilterTest.java +++ b/jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/cloud/CloudTokenDataPlaneFilterTest.java @@ -167,23 +167,28 @@ class CloudTokenDataPlaneFilterTest { } @Test - void allows_empty_clients() { - var emptyClientsFilter = new CloudTokenDataPlaneFilter( - new CloudTokenDataPlaneFilterConfig.Builder() - .tokenContext(TOKEN_CONTEXT) - .build(), - clock); - + void rejects_tokens_on_empty_clients() { var req = FilterTestUtils.newRequestBuilder() .withMethod(Method.GET) .withHeader("Authorization", "Bearer " + UNKNOWN_TOKEN.secretTokenString()) .build(); var responseHandler = new MockResponseHandler(); - emptyClientsFilter.filter(req, responseHandler); + newFilterWithEmptyClientsConfig().filter(req, responseHandler); assertNotNull(responseHandler.getResponse()); assertEquals(FORBIDDEN, responseHandler.getResponse().getStatus()); } + @Test + void rejects_missing_tokens_on_empty_clients() { + var req = FilterTestUtils.newRequestBuilder() + .withMethod(Method.GET) + .build(); + var responseHandler = new MockResponseHandler(); + newFilterWithEmptyClientsConfig().filter(req, responseHandler); + assertNotNull(responseHandler.getResponse()); + assertEquals(UNAUTHORIZED, responseHandler.getResponse().getStatus()); + } + private CloudTokenDataPlaneFilter newFilterWithClientsConfig() { return new CloudTokenDataPlaneFilter( new CloudTokenDataPlaneFilterConfig.Builder() @@ -209,4 +214,12 @@ class CloudTokenDataPlaneFilterTest { clock); } + private CloudTokenDataPlaneFilter newFilterWithEmptyClientsConfig() { + return new CloudTokenDataPlaneFilter( + new CloudTokenDataPlaneFilterConfig.Builder() + .tokenContext(TOKEN_CONTEXT) + .build(), + clock); + } + } |