Improve test

1 files changed, 21 insertions, 8 deletions

diff --git a/jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/cloud/CloudTokenDataPlaneFilterTest.java b/jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/cloud/CloudTokenDataPlaneFilterTest.java
index c34740e58a3..2ff6209fd06 100644
--- a/jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/cloud/CloudTokenDataPlaneFilterTest.java
+++ b/jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/cloud/CloudTokenDataPlaneFilterTest.java
@@ -167,23 +167,28 @@ class CloudTokenDataPlaneFilterTest {
     }
 
     @Test
-    void allows_empty_clients() {
-        var emptyClientsFilter = new CloudTokenDataPlaneFilter(
-                new CloudTokenDataPlaneFilterConfig.Builder()
-                        .tokenContext(TOKEN_CONTEXT)
-                        .build(),
-                clock);
-
+    void rejects_tokens_on_empty_clients() {
         var req = FilterTestUtils.newRequestBuilder()
                 .withMethod(Method.GET)
                 .withHeader("Authorization", "Bearer " + UNKNOWN_TOKEN.secretTokenString())
                 .build();
         var responseHandler = new MockResponseHandler();
-        emptyClientsFilter.filter(req, responseHandler);
+        newFilterWithEmptyClientsConfig().filter(req, responseHandler);
         assertNotNull(responseHandler.getResponse());
         assertEquals(FORBIDDEN, responseHandler.getResponse().getStatus());
     }
 
+    @Test
+    void rejects_missing_tokens_on_empty_clients() {
+        var req = FilterTestUtils.newRequestBuilder()
+                .withMethod(Method.GET)
+                .build();
+        var responseHandler = new MockResponseHandler();
+        newFilterWithEmptyClientsConfig().filter(req, responseHandler);
+        assertNotNull(responseHandler.getResponse());
+        assertEquals(UNAUTHORIZED, responseHandler.getResponse().getStatus());
+    }
+
     private CloudTokenDataPlaneFilter newFilterWithClientsConfig() {
         return new CloudTokenDataPlaneFilter(
                 new CloudTokenDataPlaneFilterConfig.Builder()
@@ -209,4 +214,12 @@ class CloudTokenDataPlaneFilterTest {
                 clock);
     }
 
+    private CloudTokenDataPlaneFilter newFilterWithEmptyClientsConfig() {
+        return new CloudTokenDataPlaneFilter(
+                new CloudTokenDataPlaneFilterConfig.Builder()
+                        .tokenContext(TOKEN_CONTEXT)
+                        .build(),
+                clock);
+    }
+
 }