summaryrefslogtreecommitdiffstats
path: root/jdisc-security-filters
diff options
context:
space:
mode:
authorBjørn Christian Seime <bjorncs@oath.com>2018-06-20 15:51:17 +0200
committerBjørn Christian Seime <bjorncs@oath.com>2018-06-21 12:30:52 +0200
commitb7b2ef4d5221ee069880f6412b6d9f5362c730f4 (patch)
treec58c6d81faa8f42bcf26a11173d4c3f49efcf92f /jdisc-security-filters
parent6d626db4ec8f29f57e3947350007bd366d0dfb1b (diff)
Rename 'AccessCheckResult' -> 'AuthorizationResult'
Diffstat (limited to 'jdisc-security-filters')
-rw-r--r--jdisc-security-filters/src/main/java/com/yahoo/jdisc/http/filter/security/athenz/AthenzAuthorizationFilter.java10
-rw-r--r--jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/athenz/AthenzAuthorizationFilterTest.java20
2 files changed, 15 insertions, 15 deletions
diff --git a/jdisc-security-filters/src/main/java/com/yahoo/jdisc/http/filter/security/athenz/AthenzAuthorizationFilter.java b/jdisc-security-filters/src/main/java/com/yahoo/jdisc/http/filter/security/athenz/AthenzAuthorizationFilter.java
index d586983138e..74e0ee36959 100644
--- a/jdisc-security-filters/src/main/java/com/yahoo/jdisc/http/filter/security/athenz/AthenzAuthorizationFilter.java
+++ b/jdisc-security-filters/src/main/java/com/yahoo/jdisc/http/filter/security/athenz/AthenzAuthorizationFilter.java
@@ -13,7 +13,7 @@ import com.yahoo.vespa.athenz.api.AthenzResourceName;
import com.yahoo.vespa.athenz.api.AthenzRole;
import com.yahoo.vespa.athenz.api.ZToken;
import com.yahoo.vespa.athenz.tls.AthenzX509CertificateUtils;
-import com.yahoo.vespa.athenz.zpe.AccessCheckResult;
+import com.yahoo.vespa.athenz.zpe.AuthorizationResult;
import com.yahoo.vespa.athenz.zpe.DefaultZpe;
import com.yahoo.vespa.athenz.zpe.Zpe;
@@ -120,12 +120,12 @@ public class AthenzAuthorizationFilter extends JsonSecurityRequestFilterBase {
DiscFilterRequest request,
ZpeCheck<C> accessCheck,
Function<C, AthenzPrincipal> principalFactory) {
- AccessCheckResult accessCheckResult = accessCheck.checkAccess(credentials, resAndAction.resourceName(), resAndAction.action());
- if (accessCheckResult == AccessCheckResult.ALLOW) {
+ AuthorizationResult authorizationResult = accessCheck.checkAccess(credentials, resAndAction.resourceName(), resAndAction.action());
+ if (authorizationResult == AuthorizationResult.ALLOW) {
request.setUserPrincipal(principalFactory.apply(credentials));
return Optional.empty();
}
- return Optional.of(new ErrorResponse(Response.Status.FORBIDDEN, "Access forbidden: " + accessCheckResult.getDescription()));
+ return Optional.of(new ErrorResponse(Response.Status.FORBIDDEN, "Access forbidden: " + authorizationResult.getDescription()));
}
private static AthenzPrincipal createPrincipal(X509Certificate certificate) {
@@ -139,7 +139,7 @@ public class AthenzAuthorizationFilter extends JsonSecurityRequestFilterBase {
}
@FunctionalInterface private interface ZpeCheck<C> {
- AccessCheckResult checkAccess(C credentials, AthenzResourceName resourceName, String action);
+ AuthorizationResult checkAccess(C credentials, AthenzResourceName resourceName, String action);
}
}
diff --git a/jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/athenz/AthenzAuthorizationFilterTest.java b/jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/athenz/AthenzAuthorizationFilterTest.java
index ff7f9af11c6..6137cfe9751 100644
--- a/jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/athenz/AthenzAuthorizationFilterTest.java
+++ b/jdisc-security-filters/src/test/java/com/yahoo/jdisc/http/filter/security/athenz/AthenzAuthorizationFilterTest.java
@@ -5,7 +5,7 @@ import com.yahoo.jdisc.Response;
import com.yahoo.jdisc.http.filter.DiscFilterRequest;
import com.yahoo.vespa.athenz.api.AthenzResourceName;
import com.yahoo.vespa.athenz.api.ZToken;
-import com.yahoo.vespa.athenz.zpe.AccessCheckResult;
+import com.yahoo.vespa.athenz.zpe.AuthorizationResult;
import com.yahoo.vespa.athenz.zpe.Zpe;
import org.junit.Test;
import org.mockito.Mockito;
@@ -63,7 +63,7 @@ public class AthenzAuthorizationFilterTest {
assertNotNull(response);
assertEquals(403, response.getStatus());
String content = responseHandler.readAll();
- assertThat(content, containsString(AccessCheckResult.DENY.getDescription()));
+ assertThat(content, containsString(AuthorizationResult.DENY.getDescription()));
}
private static DiscFilterRequest createRequest() {
@@ -78,25 +78,25 @@ public class AthenzAuthorizationFilterTest {
static class AllowingZpe implements Zpe {
@Override
- public AccessCheckResult checkAccessAllowed(ZToken roleToken, AthenzResourceName resourceName, String action) {
- return AccessCheckResult.ALLOW;
+ public AuthorizationResult checkAccessAllowed(ZToken roleToken, AthenzResourceName resourceName, String action) {
+ return AuthorizationResult.ALLOW;
}
@Override
- public AccessCheckResult checkAccessAllowed(X509Certificate roleCertificate, AthenzResourceName resourceName, String action) {
- return AccessCheckResult.ALLOW;
+ public AuthorizationResult checkAccessAllowed(X509Certificate roleCertificate, AthenzResourceName resourceName, String action) {
+ return AuthorizationResult.ALLOW;
}
}
static class DenyingZpe implements Zpe {
@Override
- public AccessCheckResult checkAccessAllowed(ZToken roleToken, AthenzResourceName resourceName, String action) {
- return AccessCheckResult.DENY;
+ public AuthorizationResult checkAccessAllowed(ZToken roleToken, AthenzResourceName resourceName, String action) {
+ return AuthorizationResult.DENY;
}
@Override
- public AccessCheckResult checkAccessAllowed(X509Certificate roleCertificate, AthenzResourceName resourceName, String action) {
- return AccessCheckResult.ALLOW;
+ public AuthorizationResult checkAccessAllowed(X509Certificate roleCertificate, AthenzResourceName resourceName, String action) {
+ return AuthorizationResult.ALLOW;
}
}