summaryrefslogtreecommitdiffstats
path: root/jdisc_core
diff options
context:
space:
mode:
authorgjoranv <gv@verizonmedia.com>2019-10-31 13:33:39 +0100
committergjoranv <gv@verizonmedia.com>2019-10-31 13:47:25 +0100
commiteb82e2768977558b68ea2469fdb8c1c793e3b8ae (patch)
treeb0b65be8106399f2a0b5b4ed68b6b7786700b503 /jdisc_core
parent4b7d181c3065eed971c6302179f818a60e94244f (diff)
Avoid excessive logging when no bundles are hidden.
Diffstat (limited to 'jdisc_core')
-rw-r--r--jdisc_core/src/main/java/com/yahoo/jdisc/core/BundleCollisionHook.java15
1 files changed, 14 insertions, 1 deletions
diff --git a/jdisc_core/src/main/java/com/yahoo/jdisc/core/BundleCollisionHook.java b/jdisc_core/src/main/java/com/yahoo/jdisc/core/BundleCollisionHook.java
index ae1c81195ce..8a038b79bde 100644
--- a/jdisc_core/src/main/java/com/yahoo/jdisc/core/BundleCollisionHook.java
+++ b/jdisc_core/src/main/java/com/yahoo/jdisc/core/BundleCollisionHook.java
@@ -8,6 +8,7 @@ import org.osgi.framework.Version;
import org.osgi.framework.hooks.bundle.CollisionHook;
import org.osgi.framework.hooks.bundle.EventHook;
import org.osgi.framework.hooks.bundle.FindHook;
+import org.osgi.framework.launch.Framework;
import java.util.Collection;
import java.util.HashMap;
@@ -107,7 +108,7 @@ public class BundleCollisionHook implements CollisionHook, EventHook, FindHook {
}
}
}
- log.info("Hiding bundles from bundle '" + context.getBundle() + "': " + bundlesToHide);
+ logHiddenBundles(context, bundlesToHide);
bundles.removeAll(bundlesToHide);
}
@@ -115,6 +116,18 @@ public class BundleCollisionHook implements CollisionHook, EventHook, FindHook {
return ! allowedDuplicates.containsKey(bundle) && allowedDuplicates.containsValue(new BsnVersion(bundle));
}
+ private void logHiddenBundles(BundleContext requestingContext, Set<Bundle> hiddenBundles) {
+ if (hiddenBundles.isEmpty()) {
+ log.fine(() -> "No bundles to hide from bundle " + requestingContext.getBundle());
+ } else {
+ if (requestingContext.getBundle() instanceof Framework) {
+ log.fine(() -> "Requesting bundle is the Framework, so hidden bundles will be visible: " + hiddenBundles);
+ } else {
+ log.info("Hiding bundles from bundle '" + requestingContext.getBundle() + "': " + hiddenBundles);
+ }
+ }
+ }
+
static class BsnVersion {