diff options
author | gjoranv <gv@yahoo-inc.com> | 2017-03-08 17:45:34 +0100 |
---|---|---|
committer | gjoranv <gv@yahoo-inc.com> | 2017-03-08 17:45:34 +0100 |
commit | 4b9619ac4de01f20f4ea2ed6e2f6e5f6f75ad1ad (patch) | |
tree | 3d468f606382309379d156afc46913eb260bca66 /jdisc_http_service/src/test/java/com/yahoo/jdisc/http | |
parent | a71f30e3df4d4f6240c070af9bab30f764f3eaa3 (diff) |
Extract helper method to improve legibility.
Diffstat (limited to 'jdisc_http_service/src/test/java/com/yahoo/jdisc/http')
-rw-r--r-- | jdisc_http_service/src/test/java/com/yahoo/jdisc/http/filter/RequestViewImplTest.java | 19 |
1 files changed, 11 insertions, 8 deletions
diff --git a/jdisc_http_service/src/test/java/com/yahoo/jdisc/http/filter/RequestViewImplTest.java b/jdisc_http_service/src/test/java/com/yahoo/jdisc/http/filter/RequestViewImplTest.java index 7ba40a04253..d8ba8bac14a 100644 --- a/jdisc_http_service/src/test/java/com/yahoo/jdisc/http/filter/RequestViewImplTest.java +++ b/jdisc_http_service/src/test/java/com/yahoo/jdisc/http/filter/RequestViewImplTest.java @@ -23,16 +23,14 @@ public class RequestViewImplTest { HeaderFields parentHeaders = new HeaderFields(); parentHeaders.add(HEADER, "value"); - Request request = mock(Request.class); - when(request.headers()).thenReturn(parentHeaders); - - RequestView requestView = new RequestViewImpl(request); + RequestView requestView = newRequestView(parentHeaders); assertEquals(requestView.getFirstHeader(HEADER).get(), "value"); assertEquals(requestView.getHeaders(HEADER).size(), 1); assertEquals(requestView.getHeaders(HEADER).get(0), "value"); } + @Test public void multi_value_header_from_the_parent_request_is_available() throws Exception { final String HEADER = "list-header"; @@ -40,10 +38,7 @@ public class RequestViewImplTest { HeaderFields parentHeaders = new HeaderFields(); parentHeaders.add(HEADER, Lists.newArrayList("one", "two")); - Request request = mock(Request.class); - when(request.headers()).thenReturn(parentHeaders); - - RequestView requestView = new RequestViewImpl(request); + RequestView requestView = newRequestView(parentHeaders); assertEquals(requestView.getHeaders(HEADER).size(), 2); assertEquals(requestView.getHeaders(HEADER).get(0), "one"); @@ -51,4 +46,12 @@ public class RequestViewImplTest { assertEquals(requestView.getFirstHeader(HEADER).get(), "one"); } + + private static RequestView newRequestView(HeaderFields parentHeaders) { + Request request = mock(Request.class); + when(request.headers()).thenReturn(parentHeaders); + + return new RequestViewImpl(request); + } + } |