diff options
author | Morten Tokle <mortent@verizonmedia.com> | 2021-01-20 23:44:13 +0100 |
---|---|---|
committer | Morten Tokle <mortent@verizonmedia.com> | 2021-01-21 15:04:22 +0100 |
commit | 81abd1d4c3bf731847bda97b5f11abb073af490a (patch) | |
tree | 0ba2d223091c4cc084be3e24ef3d98ee452d0dbb /jdisc_http_service | |
parent | 99dff1d3c48ac9a481f25831c877bc51109848eb (diff) |
Publish log records directly
Diffstat (limited to 'jdisc_http_service')
3 files changed, 8 insertions, 10 deletions
diff --git a/jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLogHandler.java b/jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLogHandler.java index 14236452ac0..64f858ce26e 100644 --- a/jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLogHandler.java +++ b/jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLogHandler.java @@ -3,23 +3,24 @@ package com.yahoo.container.logging; import com.yahoo.container.core.AccessLogConfig; -import java.util.logging.Logger; +import java.util.logging.Level; +import java.util.logging.LogRecord; /** * @author Bjorn Borud */ class AccessLogHandler { - public final Logger access = Logger.getAnonymousLogger(); private final LogFileHandler logFileHandler; AccessLogHandler(AccessLogConfig.FileHandler config) { - access.setUseParentHandlers(false); - LogFormatter lf = new LogFormatter(); lf.messageOnly(true); logFileHandler = new LogFileHandler(toCompression(config), config.pattern(), config.rotation(), config.symlink(), lf); - access.addHandler(this.logFileHandler); + } + + public void log(String message) { + logFileHandler.publish(new LogRecord(Level.INFO, message)); } private LogFileHandler.Compression toCompression(AccessLogConfig.FileHandler config) { @@ -33,7 +34,6 @@ class AccessLogHandler { void shutdown() { logFileHandler.close(); - access.removeHandler(logFileHandler); if (logFileHandler!=null) logFileHandler.shutdown(); diff --git a/jdisc_http_service/src/main/java/com/yahoo/container/logging/JSONAccessLog.java b/jdisc_http_service/src/main/java/com/yahoo/container/logging/JSONAccessLog.java index aa2df959a4c..6fc4e886ec5 100644 --- a/jdisc_http_service/src/main/java/com/yahoo/container/logging/JSONAccessLog.java +++ b/jdisc_http_service/src/main/java/com/yahoo/container/logging/JSONAccessLog.java @@ -3,8 +3,6 @@ package com.yahoo.container.logging; import com.yahoo.container.core.AccessLogConfig; -import java.util.logging.Level; - /** * Log a message in Vespa JSON access log format. * @@ -23,7 +21,7 @@ public final class JSONAccessLog implements RequestLogHandler { @Override public void log(RequestLogEntry entry) { - logHandler.access.log(Level.INFO, formatter.format(entry) + '\n'); + logHandler.log(formatter.format(entry) + '\n'); } // TODO: This is never called. We should have a DI provider and call this method from its deconstruct. diff --git a/jdisc_http_service/src/main/java/com/yahoo/container/logging/VespaAccessLog.java b/jdisc_http_service/src/main/java/com/yahoo/container/logging/VespaAccessLog.java index 1040846dda3..347500a8c07 100644 --- a/jdisc_http_service/src/main/java/com/yahoo/container/logging/VespaAccessLog.java +++ b/jdisc_http_service/src/main/java/com/yahoo/container/logging/VespaAccessLog.java @@ -69,7 +69,7 @@ public final class VespaAccessLog implements RequestLogHandler { .append(" 0.0 ") .append((hitcounts == null) ? 0 : hitcounts.getSummaryCount()) .append('\n'); - logHandler.access.log(Level.INFO, sb.toString()); + logHandler.log(sb.toString()); } private void decimalsOfSecondsFromMilliseconds(long ms, StringBuilder sb) { |