diff options
author | Bjørn Christian Seime <bjorncs@verizonmedia.com> | 2019-10-08 11:46:06 +0200 |
---|---|---|
committer | Bjørn Christian Seime <bjorncs@verizonmedia.com> | 2019-10-08 11:46:06 +0200 |
commit | 8ddecf071e1d23f985649bb1029c802c6045de6e (patch) | |
tree | a89c8279a69432b7a6f04b20b371dd5544142a2c /jdisc_http_service | |
parent | 7fdcde5427339d785d9530ee76b634665144977a (diff) |
Always include peer port/address in access log
Diffstat (limited to 'jdisc_http_service')
-rw-r--r-- | jdisc_http_service/src/main/java/com/yahoo/jdisc/http/server/jetty/AccessLogRequestLog.java | 19 |
1 files changed, 10 insertions, 9 deletions
diff --git a/jdisc_http_service/src/main/java/com/yahoo/jdisc/http/server/jetty/AccessLogRequestLog.java b/jdisc_http_service/src/main/java/com/yahoo/jdisc/http/server/jetty/AccessLogRequestLog.java index 9a10c70ceab..1d3edc1240e 100644 --- a/jdisc_http_service/src/main/java/com/yahoo/jdisc/http/server/jetty/AccessLogRequestLog.java +++ b/jdisc_http_service/src/main/java/com/yahoo/jdisc/http/server/jetty/AccessLogRequestLog.java @@ -58,23 +58,24 @@ public class AccessLogRequestLog extends AbstractLifeCycle implements RequestLog accessLogEntry.setRawQuery(queryString); } - final String remoteAddress = getRemoteAddress(request); - final int remotePort = getRemotePort(request); - final String peerAddress = request.getRemoteAddr(); - final int peerPort = request.getRemotePort(); - accessLogEntry.setUserAgent(request.getHeader("User-Agent")); accessLogEntry.setHttpMethod(request.getMethod()); accessLogEntry.setHostString(request.getHeader("Host")); accessLogEntry.setReferer(request.getHeader("Referer")); + + String peerAddress = request.getRemoteAddr(); accessLogEntry.setIpV4Address(peerAddress); - accessLogEntry.setRemoteAddress(remoteAddress); - accessLogEntry.setRemotePort(remotePort); + accessLogEntry.setPeerAddress(peerAddress); + String remoteAddress = getRemoteAddress(request); if (!Objects.equal(remoteAddress, peerAddress)) { - accessLogEntry.setPeerAddress(peerAddress); + accessLogEntry.setRemoteAddress(remoteAddress); } + + int peerPort = request.getRemotePort(); + accessLogEntry.setPeerPort(peerPort); + int remotePort = getRemotePort(request); if (remotePort != peerPort) { - accessLogEntry.setPeerPort(peerPort); + accessLogEntry.setRemotePort(remotePort); } accessLogEntry.setHttpVersion(request.getProtocol()); accessLogEntry.setScheme(request.getScheme()); |