diff options
author | Håvard Pettersen <havardpe@oath.com> | 2019-10-17 14:01:25 +0000 |
---|---|---|
committer | Håvard Pettersen <havardpe@oath.com> | 2019-10-17 14:01:25 +0000 |
commit | 8cbb3098b378827aaf08523834201b0df2d665b5 (patch) | |
tree | 377e905ddcbc2c54ca6caeabd1f5b7cc521a66db /jrt | |
parent | 4d4fdd01ac742e752d1f7addde679ea268b8a47f (diff) |
auto-compact empty buffers when requesting writable view
Diffstat (limited to 'jrt')
-rw-r--r-- | jrt/src/com/yahoo/jrt/Buffer.java | 7 | ||||
-rw-r--r-- | jrt/tests/com/yahoo/jrt/BufferTest.java | 15 |
2 files changed, 21 insertions, 1 deletions
diff --git a/jrt/src/com/yahoo/jrt/Buffer.java b/jrt/src/com/yahoo/jrt/Buffer.java index e57eda3473f..1014dc40014 100644 --- a/jrt/src/com/yahoo/jrt/Buffer.java +++ b/jrt/src/com/yahoo/jrt/Buffer.java @@ -32,7 +32,12 @@ class Buffer { } readPos = buf.position(); buf.limit(buf.capacity()); - buf.position(writePos); + if (readPos == writePos) { + readPos = 0; + buf.position(0); + } else { + buf.position(writePos); + } readMode = false; } diff --git a/jrt/tests/com/yahoo/jrt/BufferTest.java b/jrt/tests/com/yahoo/jrt/BufferTest.java index f837b036957..7f3145365d9 100644 --- a/jrt/tests/com/yahoo/jrt/BufferTest.java +++ b/jrt/tests/com/yahoo/jrt/BufferTest.java @@ -11,6 +11,21 @@ import static org.junit.Assert.assertTrue; public class BufferTest { @org.junit.Test + public void testEmptyBufferAutoCompact() { + Buffer buf = new Buffer(1024); + ByteBuffer b = buf.getWritable(10); + for (int x = 0; x < 10; x++) { + b.put((byte)x); + } + b = buf.getReadable(); + while (b.remaining() > 0) { + b.get(); + } + b = buf.getWritable(10); + assertEquals(1024, b.remaining()); + } + + @org.junit.Test public void testBuffer() { int size = Buffer.MAX_IO + (Buffer.MAX_IO / 10); |