summaryrefslogtreecommitdiffstats
path: root/linguistics
diff options
context:
space:
mode:
authorJon Marius Venstad <venstad@gmail.com>2021-12-17 14:14:49 +0100
committerJon Marius Venstad <venstad@gmail.com>2021-12-17 15:31:40 +0100
commitf771efc9dcd25b36daca2a042d0b5d89fef7d46a (patch)
treef08d3c8ac72639e6ff6f8d8a83a018448212b3f0 /linguistics
parent675ac2a7bf14ff5976aa1abbf3073ccd0f6f2274 (diff)
Add some javadoc, and no need to handle null return for model
Diffstat (limited to 'linguistics')
-rw-r--r--linguistics/src/main/java/com/yahoo/language/opennlp/LangDetectModel.java3
-rw-r--r--linguistics/src/main/java/com/yahoo/language/opennlp/OpenNlpLinguistics.java3
2 files changed, 4 insertions, 2 deletions
diff --git a/linguistics/src/main/java/com/yahoo/language/opennlp/LangDetectModel.java b/linguistics/src/main/java/com/yahoo/language/opennlp/LangDetectModel.java
index 70664b8f79f..144b4612005 100644
--- a/linguistics/src/main/java/com/yahoo/language/opennlp/LangDetectModel.java
+++ b/linguistics/src/main/java/com/yahoo/language/opennlp/LangDetectModel.java
@@ -4,10 +4,13 @@ package com.yahoo.language.opennlp;
import opennlp.tools.langdetect.LanguageDetectorModel;
/**
+ * Wrapper to lazily load a langdetect model for OpenNLP.
+ *
* @author jonmv
*/
public interface LangDetectModel {
+ /** Loads a {@link LanguageDetectorModel}, or throws if this fails. */
LanguageDetectorModel load();
}
diff --git a/linguistics/src/main/java/com/yahoo/language/opennlp/OpenNlpLinguistics.java b/linguistics/src/main/java/com/yahoo/language/opennlp/OpenNlpLinguistics.java
index 7ee17559d88..1f4ec4e261b 100644
--- a/linguistics/src/main/java/com/yahoo/language/opennlp/OpenNlpLinguistics.java
+++ b/linguistics/src/main/java/com/yahoo/language/opennlp/OpenNlpLinguistics.java
@@ -21,8 +21,7 @@ public class OpenNlpLinguistics extends SimpleLinguistics {
@Inject
public OpenNlpLinguistics(LangDetectModel model) {
- LanguageDetectorModel loaded = model.load();
- this.detector = loaded != null ? new OpenNlpDetector(loaded) : new SimpleDetector();
+ this.detector = new OpenNlpDetector(model.load());
}
@Override