Merge pull request #9506 from vespa-engine/arnej/use-try-with-resources

use try-with-resources to ensure streams are closed

1 files changed, 3 insertions, 5 deletions

diff --git a/logserver/src/main/java/com/yahoo/logserver/handlers/archive/FilesArchived.java b/logserver/src/main/java/com/yahoo/logserver/handlers/archive/FilesArchived.java
index fa716921be5..ff082f7efba 100644
--- a/logserver/src/main/java/com/yahoo/logserver/handlers/archive/FilesArchived.java
+++ b/logserver/src/main/java/com/yahoo/logserver/handlers/archive/FilesArchived.java
@@ -113,19 +113,17 @@ public class FilesArchived {
 
     private void compress(File oldFile) {
         File gzippedFile = new File(oldFile.getPath() + ".gz");
-        try {
+        try (GZIPOutputStream compressor = new GZIPOutputStream(new FileOutputStream(gzippedFile), 0x100000);
+             FileInputStream inputStream = new FileInputStream(oldFile))
+        {
             long mtime = oldFile.lastModified();
-            GZIPOutputStream compressor = new GZIPOutputStream(new FileOutputStream(gzippedFile), 0x100000);
-            FileInputStream inputStream = new FileInputStream(oldFile);
             byte [] buffer = new byte[0x100000];
 
             for (int read = inputStream.read(buffer); read > 0; read = inputStream.read(buffer)) {
                 compressor.write(buffer, 0, read);
             }
-            inputStream.close();
             compressor.finish();
             compressor.flush();
-            compressor.close();
             oldFile.delete();
             gzippedFile.setLastModified(mtime);
             log.info("Compressed: "+gzippedFile);