summaryrefslogtreecommitdiffstats
path: root/logserver
diff options
context:
space:
mode:
authorArne H Juul <arnej@yahoo-inc.com>2017-04-24 12:41:12 +0200
committerArne H Juul <arnej@yahoo-inc.com>2017-04-24 12:41:29 +0200
commit9c9cf41bea483b8c1490a9aca7444a042e747624 (patch)
tree02286f0b92acc650d8a4c112effb653cbb359be9 /logserver
parent33f343a2303af39a0945964947bf421f37bd7ff7 (diff)
fix warnings
* remove unneeded casts * use class name, not instance, to call static methods
Diffstat (limited to 'logserver')
-rw-r--r--logserver/src/main/java/com/yahoo/logserver/handlers/HandlerThread.java4
-rw-r--r--logserver/src/main/java/com/yahoo/logserver/handlers/archive/LogWriterLRUCache.java2
-rw-r--r--logserver/src/test/java/com/yahoo/logserver/FlusherTestCase.java2
-rw-r--r--logserver/src/test/java/com/yahoo/logserver/handlers/HandlerThreadTestCase.java6
4 files changed, 7 insertions, 7 deletions
diff --git a/logserver/src/main/java/com/yahoo/logserver/handlers/HandlerThread.java b/logserver/src/main/java/com/yahoo/logserver/handlers/HandlerThread.java
index 8af5202739b..15c44d6e197 100644
--- a/logserver/src/main/java/com/yahoo/logserver/handlers/HandlerThread.java
+++ b/logserver/src/main/java/com/yahoo/logserver/handlers/HandlerThread.java
@@ -123,7 +123,7 @@ public class HandlerThread extends Thread implements LogHandler
public void flush () {
Iterator<LogHandler> it = handlers.iterator();
while (it.hasNext()) {
- LogHandler handler = (LogHandler)it.next();
+ LogHandler handler = it.next();
handler.flush();
}
}
@@ -131,7 +131,7 @@ public class HandlerThread extends Thread implements LogHandler
public void close () {
Iterator<LogHandler> it = handlers.iterator();
while (it.hasNext()) {
- LogHandler handler = (LogHandler)it.next();
+ LogHandler handler = it.next();
handler.close();
}
}
diff --git a/logserver/src/main/java/com/yahoo/logserver/handlers/archive/LogWriterLRUCache.java b/logserver/src/main/java/com/yahoo/logserver/handlers/archive/LogWriterLRUCache.java
index 21ca26efdd2..d36486e0c44 100644
--- a/logserver/src/main/java/com/yahoo/logserver/handlers/archive/LogWriterLRUCache.java
+++ b/logserver/src/main/java/com/yahoo/logserver/handlers/archive/LogWriterLRUCache.java
@@ -26,7 +26,7 @@ public class LogWriterLRUCache extends LinkedHashMap<Integer, LogWriter>
// TODO: implement unit test for this
protected boolean removeEldestEntry (Map.Entry<Integer, LogWriter> eldest) {
if (size() > maxEntries) {
- LogWriter logWriter = (LogWriter)eldest.getValue();
+ LogWriter logWriter = eldest.getValue();
log.fine("Closing oldest LogWriter: " + logWriter);
try {
logWriter.close();
diff --git a/logserver/src/test/java/com/yahoo/logserver/FlusherTestCase.java b/logserver/src/test/java/com/yahoo/logserver/FlusherTestCase.java
index d74504b5ed0..79d16de61f0 100644
--- a/logserver/src/test/java/com/yahoo/logserver/FlusherTestCase.java
+++ b/logserver/src/test/java/com/yahoo/logserver/FlusherTestCase.java
@@ -14,7 +14,7 @@ public class FlusherTestCase {
public void testFlusher() throws InterruptedException {
Flusher flusher = new Flusher();
LogDispatcherTestCase.MockHandler handler = new LogDispatcherTestCase.MockHandler();
- flusher.register(handler);
+ Flusher.register(handler);
flusher.start();
Thread.sleep(5000);
flusher.interrupt();
diff --git a/logserver/src/test/java/com/yahoo/logserver/handlers/HandlerThreadTestCase.java b/logserver/src/test/java/com/yahoo/logserver/handlers/HandlerThreadTestCase.java
index 16c1c780bb1..930b6e7c5ad 100644
--- a/logserver/src/test/java/com/yahoo/logserver/handlers/HandlerThreadTestCase.java
+++ b/logserver/src/test/java/com/yahoo/logserver/handlers/HandlerThreadTestCase.java
@@ -49,14 +49,14 @@ public class HandlerThreadTestCase {
final LogMessage msg3 = LogMessage.parseNativeFormat(msgstr3);
thread.handle(msg1);
while ((h1.messages.size() < 1) || (h2.messages.size() < 1) || (h3.messages.size() < 1)) {
- thread.sleep(10);
+ Thread.sleep(10);
}
assertEquals(h1.messages.size(), 1);
assertEquals(h2.messages.size(), 1);
assertEquals(h3.messages.size(), 1);
thread.handle(new ArrayList<LogMessage>() {{add(msg1); add(msg2); add(msg3); }});
while ((h1.messages.size() < 4) || (h2.messages.size() < 4) || (h3.messages.size() < 4)) {
- thread.sleep(10);
+ Thread.sleep(10);
}
assertEquals(h1.messages.size(), 4);
assertEquals(h2.messages.size(), 4);
@@ -86,7 +86,7 @@ public class HandlerThreadTestCase {
final LogMessage msg1 = LogMessage.parseNativeFormat(msgstr1);
thread.handle(msg1);
while (h1.messages.size() < 1) {
- thread.sleep(10);
+ Thread.sleep(10);
}
assertEquals(h1.messages.size(), 1);
thread.interrupt();