aboutsummaryrefslogtreecommitdiffstats
path: root/messagebus
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2017-06-13 19:42:29 +0200
committerHenning Baldersheim <balder@yahoo-inc.com>2017-06-13 19:42:29 +0200
commit28862ccc448cae25719452e7f29d16872498fbbb (patch)
tree692ad583199e450b1ce8f82b2d9d88d1ce1e62e4 /messagebus
parent4ae60e3fbc20e0397662c39848cab012ff052e5e (diff)
Avoid potential NullPtrException and add some more information in case something odd happens.
Diffstat (limited to 'messagebus')
-rwxr-xr-xmessagebus/src/main/java/com/yahoo/messagebus/routing/RoutingContext.java5
-rwxr-xr-xmessagebus/src/main/java/com/yahoo/messagebus/routing/RoutingNode.java2
-rwxr-xr-xmessagebus/src/test/java/com/yahoo/messagebus/routing/RoutingContextTestCase.java4
3 files changed, 10 insertions, 1 deletions
diff --git a/messagebus/src/main/java/com/yahoo/messagebus/routing/RoutingContext.java b/messagebus/src/main/java/com/yahoo/messagebus/routing/RoutingContext.java
index c6b26ffe3e2..e4efd951366 100755
--- a/messagebus/src/main/java/com/yahoo/messagebus/routing/RoutingContext.java
+++ b/messagebus/src/main/java/com/yahoo/messagebus/routing/RoutingContext.java
@@ -34,6 +34,11 @@ public class RoutingContext {
this.directive = directive;
}
+ public String toString() {
+ return "node : " + node + ", directive: " + directive + ", errors: " + consumableErrors +
+ ", selectOnRetry: " + selectOnRetry + " context: " + context;
+ }
+
/**
* <p>Returns whether or not this hop has any configured recipients.</p>
*
diff --git a/messagebus/src/main/java/com/yahoo/messagebus/routing/RoutingNode.java b/messagebus/src/main/java/com/yahoo/messagebus/routing/RoutingNode.java
index b69e24eb55c..1169973f118 100755
--- a/messagebus/src/main/java/com/yahoo/messagebus/routing/RoutingNode.java
+++ b/messagebus/src/main/java/com/yahoo/messagebus/routing/RoutingNode.java
@@ -492,7 +492,7 @@ public class RoutingNode implements ReplyHandler {
return false;
}
- private String exceptionMessageWithTrace(Exception e) {
+ private static String exceptionMessageWithTrace(Exception e) {
StringWriter sw = new StringWriter();
try (PrintWriter pw = new PrintWriter(sw)) {
e.printStackTrace(pw);
diff --git a/messagebus/src/test/java/com/yahoo/messagebus/routing/RoutingContextTestCase.java b/messagebus/src/test/java/com/yahoo/messagebus/routing/RoutingContextTestCase.java
index 4ca97dc80ec..0c738db4242 100755
--- a/messagebus/src/test/java/com/yahoo/messagebus/routing/RoutingContextTestCase.java
+++ b/messagebus/src/test/java/com/yahoo/messagebus/routing/RoutingContextTestCase.java
@@ -121,6 +121,10 @@ public class RoutingContextTestCase extends junit.framework.TestCase {
}
}
+ public void testToString() {
+ assertEquals("node : null, directive: 1, errors: [], selectOnRetry: true context: null", new RoutingContext(null, 1).toString());
+ }
+
public void testConstRoute() {
SimpleProtocol protocol = new SimpleProtocol();
protocol.addPolicyFactory("DocumentRouteSelector",