summaryrefslogtreecommitdiffstats
path: root/messagebus
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2023-02-01 20:23:03 +0000
committerHenning Baldersheim <balder@yahoo-inc.com>2023-02-01 20:31:30 +0000
commit9f502a22ca42e3e9e143f24aae24e03ab82ea304 (patch)
tree8877be6972edca32247eefd1a712ca29770ae00e /messagebus
parent54cd94fa8d90a8b56c4b64ab2aba3b9c1d5bc5d9 (diff)
deinline destructors.
Diffstat (limited to 'messagebus')
-rw-r--r--messagebus/src/vespa/messagebus/iconfighandler.h2
-rw-r--r--messagebus/src/vespa/messagebus/network/rpcsendv2.cpp5
-rw-r--r--messagebus/src/vespa/messagebus/testlib/slobrok.cpp3
-rw-r--r--messagebus/src/vespa/messagebus/testlib/testserver.cpp2
-rw-r--r--messagebus/src/vespa/messagebus/testlib/testserver.h1
5 files changed, 11 insertions, 2 deletions
diff --git a/messagebus/src/vespa/messagebus/iconfighandler.h b/messagebus/src/vespa/messagebus/iconfighandler.h
index 91398629ca8..5cfd26b6440 100644
--- a/messagebus/src/vespa/messagebus/iconfighandler.h
+++ b/messagebus/src/vespa/messagebus/iconfighandler.h
@@ -15,7 +15,7 @@ class RoutingSpec;
class IConfigHandler
{
public:
- virtual ~IConfigHandler() {}
+ virtual ~IConfigHandler() = default;
/**
* This method will be invoked to initialize or change the routing
diff --git a/messagebus/src/vespa/messagebus/network/rpcsendv2.cpp b/messagebus/src/vespa/messagebus/network/rpcsendv2.cpp
index c211ff83110..18e29451a0d 100644
--- a/messagebus/src/vespa/messagebus/network/rpcsendv2.cpp
+++ b/messagebus/src/vespa/messagebus/network/rpcsendv2.cpp
@@ -88,11 +88,12 @@ namespace {
class OutputBuf : public vespalib::Output {
public:
explicit OutputBuf(size_t estimatedSize) : _buf(estimatedSize) { }
+ ~OutputBuf() override;
DataBuffer & getBuf() { return _buf; }
private:
vespalib::WritableMemory reserve(size_t bytes) override {
_buf.ensureFree(bytes);
- return vespalib::WritableMemory(_buf.getFree(), _buf.getFreeLen());
+ return {_buf.getFree(), _buf.getFreeLen()};
}
Output &commit(size_t bytes) override {
_buf.moveFreeToData(bytes);
@@ -100,6 +101,8 @@ private:
}
DataBuffer _buf;
};
+OutputBuf::~OutputBuf() = default;
+
}
void
diff --git a/messagebus/src/vespa/messagebus/testlib/slobrok.cpp b/messagebus/src/vespa/messagebus/testlib/slobrok.cpp
index bcf6f829605..889daf538a3 100644
--- a/messagebus/src/vespa/messagebus/testlib/slobrok.cpp
+++ b/messagebus/src/vespa/messagebus/testlib/slobrok.cpp
@@ -18,6 +18,7 @@ private:
std::condition_variable _cond;
public:
explicit WaitTask(FNET_Scheduler *s) : FNET_Task(s), _done(false), _mon() {}
+ ~WaitTask() override;
void wait() {
std::unique_lock guard(_mon);
while (!_done) {
@@ -31,6 +32,8 @@ public:
_cond.notify_one();
}
};
+
+WaitTask::~WaitTask() = default;
} // namespace <unnamed>
namespace mbus {
diff --git a/messagebus/src/vespa/messagebus/testlib/testserver.cpp b/messagebus/src/vespa/messagebus/testlib/testserver.cpp
index d289c372fda..4393dfccccc 100644
--- a/messagebus/src/vespa/messagebus/testlib/testserver.cpp
+++ b/messagebus/src/vespa/messagebus/testlib/testserver.cpp
@@ -13,6 +13,8 @@ VersionedRPCNetwork::VersionedRPCNetwork(const RPCNetworkParams &params) :
_version(vespalib::Vtag::currentVersion)
{}
+VersionedRPCNetwork::~VersionedRPCNetwork() = default;
+
void
VersionedRPCNetwork::setVersion(const vespalib::Version &version)
{
diff --git a/messagebus/src/vespa/messagebus/testlib/testserver.h b/messagebus/src/vespa/messagebus/testlib/testserver.h
index 1ea96c3e13f..f3f349e52b9 100644
--- a/messagebus/src/vespa/messagebus/testlib/testserver.h
+++ b/messagebus/src/vespa/messagebus/testlib/testserver.h
@@ -23,6 +23,7 @@ protected:
public:
VersionedRPCNetwork(const RPCNetworkParams &params);
+ ~VersionedRPCNetwork() override;
void setVersion(const vespalib::Version &version);
};