summaryrefslogtreecommitdiffstats
path: root/messagebus
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2020-03-24 23:19:37 +0000
committerHenning Baldersheim <balder@yahoo-inc.com>2020-03-25 00:37:24 +0000
commit92fe414f7fa06496499e3946c0b30c3ad2bb67ff (patch)
tree3acdddeeaa9b7e67a15271484944faa5b1975fcc /messagebus
parent8e75db35580a17a1b202f104e2f25a722f20d8a3 (diff)
std::move
Diffstat (limited to 'messagebus')
-rw-r--r--messagebus/src/vespa/messagebus/network/rpcnetwork.cpp5
-rw-r--r--messagebus/src/vespa/messagebus/network/rpcserviceaddress.h2
-rw-r--r--messagebus/src/vespa/messagebus/network/rpctargetpool.cpp2
3 files changed, 5 insertions, 4 deletions
diff --git a/messagebus/src/vespa/messagebus/network/rpcnetwork.cpp b/messagebus/src/vespa/messagebus/network/rpcnetwork.cpp
index c6f61b383bc..4e8e5bdd7dd 100644
--- a/messagebus/src/vespa/messagebus/network/rpcnetwork.cpp
+++ b/messagebus/src/vespa/messagebus/network/rpcnetwork.cpp
@@ -130,6 +130,7 @@ RPCNetwork::RPCNetwork(const RPCNetworkParams &params) :
{
_transport->SetMaxInputBufferSize(params.getMaxInputBufferSize());
_transport->SetMaxOutputBufferSize(params.getMaxOutputBufferSize());
+ _transport->SetTCPNoDelay(false);
}
RPCNetwork::~RPCNetwork()
@@ -306,8 +307,8 @@ RPCNetwork::resolveServiceAddress(RoutingNode &recipient, const string &serviceN
make_string("Failed to connect to service '%s' from host '%s'.",
serviceName.c_str(), getIdentity().getHostname().c_str()));
}
- ret->setTarget(target); // free by freeServiceAddress()
- recipient.setServiceAddress(IServiceAddress::UP(ret.release()));
+ ret->setTarget(std::move(target)); // free by freeServiceAddress()
+ recipient.setServiceAddress(std::move(ret));
return Error();
}
diff --git a/messagebus/src/vespa/messagebus/network/rpcserviceaddress.h b/messagebus/src/vespa/messagebus/network/rpcserviceaddress.h
index 36dde19bd18..142e654cc06 100644
--- a/messagebus/src/vespa/messagebus/network/rpcserviceaddress.h
+++ b/messagebus/src/vespa/messagebus/network/rpcserviceaddress.h
@@ -84,7 +84,7 @@ public:
*
* @return True if target is set.
*/
- bool hasTarget() const { return _target.get() != nullptr; }
+ bool hasTarget() const { return bool(_target); }
};
} // namespace mbus
diff --git a/messagebus/src/vespa/messagebus/network/rpctargetpool.cpp b/messagebus/src/vespa/messagebus/network/rpctargetpool.cpp
index 7fcc214faa7..dd977efec08 100644
--- a/messagebus/src/vespa/messagebus/network/rpctargetpool.cpp
+++ b/messagebus/src/vespa/messagebus/network/rpctargetpool.cpp
@@ -74,7 +74,7 @@ RPCTargetPool::getTarget(FRT_Supervisor &orb, const RPCServiceAddress &address)
}
_targets.erase(it);
}
- RPCTarget::SP ret(new RPCTarget(spec, orb));
+ auto ret = std::make_shared<RPCTarget>(spec, orb);
_targets.insert(TargetMap::value_type(spec, Entry(ret, _timer->getMilliTime())));
return ret;
}