summaryrefslogtreecommitdiffstats
path: root/messagebus
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2020-11-17 23:48:20 +0000
committerHenning Baldersheim <balder@yahoo-inc.com>2020-11-18 18:22:16 +0000
commitb2d2d0053d16ca15c9298f3e8312b494e246c5e9 (patch)
tree6a9670dae20080e9a59eca882962c4ced94e9640 /messagebus
parentd6975953e4284068fbd76e80bbf7e802003adcaf (diff)
No need to copy an empty object into another empty object.
Diffstat (limited to 'messagebus')
-rw-r--r--messagebus/src/vespa/messagebus/routing/routingnode.cpp2
-rw-r--r--messagebus/src/vespa/messagebus/sendproxy.cpp3
2 files changed, 2 insertions, 3 deletions
diff --git a/messagebus/src/vespa/messagebus/routing/routingnode.cpp b/messagebus/src/vespa/messagebus/routing/routingnode.cpp
index f24afbc07ca..3a433b05bc5 100644
--- a/messagebus/src/vespa/messagebus/routing/routingnode.cpp
+++ b/messagebus/src/vespa/messagebus/routing/routingnode.cpp
@@ -184,7 +184,7 @@ RoutingNode::setReply(Reply::UP reply)
{
if (reply) {
_shouldRetry = _resender != nullptr && _resender->shouldRetry(*reply);
- if ( ! reply->getTrace().getRoot().isEmpty()) {
+ if ( ! reply->getTrace().isEmpty()) {
_trace.getRoot().addChild(std::move(reply->getTrace().getRoot()));
reply->getTrace().clear();
}
diff --git a/messagebus/src/vespa/messagebus/sendproxy.cpp b/messagebus/src/vespa/messagebus/sendproxy.cpp
index c884932664b..fa485e19bb8 100644
--- a/messagebus/src/vespa/messagebus/sendproxy.cpp
+++ b/messagebus/src/vespa/messagebus/sendproxy.cpp
@@ -53,8 +53,7 @@ SendProxy::handleReply(Reply::UP reply)
} else if (logger.wants(ns_log::Logger::spam)) {
LOG(spam, "Trace for reply:\n%s", reply->getTrace().toString().c_str());
}
- Trace empty;
- trace.swap(empty);
+ trace.clear();
} else if (trace.getLevel() > 0) {
trace.getRoot().addChild(reply->getTrace().getRoot());
trace.getRoot().normalize();