summaryrefslogtreecommitdiffstats
path: root/messagebus
diff options
context:
space:
mode:
authorTor Egge <Tor.Egge@online.no>2022-02-26 21:24:02 +0100
committerTor Egge <Tor.Egge@online.no>2022-02-26 21:24:02 +0100
commit408f1f7bb616fb2b3af37f6faa22febc34dec86a (patch)
tree04aa1fec948e71bb1069e03268851dcd40d3fbc1 /messagebus
parent55762ffec0bda1fb31b64500c4efe45d355757d4 (diff)
Remove inlining warnings (messagebus).
Diffstat (limited to 'messagebus')
-rw-r--r--messagebus/src/tests/routing/routing.cpp12
-rw-r--r--messagebus/src/tests/routingcontext/routingcontext.cpp3
-rw-r--r--messagebus/src/tests/sendadapter/sendadapter.cpp3
-rw-r--r--messagebus/src/vespa/messagebus/routing/routingtablespec.cpp4
-rw-r--r--messagebus/src/vespa/messagebus/routing/routingtablespec.h4
-rw-r--r--messagebus/src/vespa/messagebus/testlib/simpleprotocol.cpp6
6 files changed, 32 insertions, 0 deletions
diff --git a/messagebus/src/tests/routing/routing.cpp b/messagebus/src/tests/routing/routing.cpp
index 20468945edd..aefbd8816c6 100644
--- a/messagebus/src/tests/routing/routing.cpp
+++ b/messagebus/src/tests/routing/routing.cpp
@@ -84,9 +84,12 @@ public:
RemoveReplyPolicyFactory(bool selectOnRetry,
const std::vector<uint32_t> &consumableErrors,
uint32_t idxRemove);
+ ~RemoveReplyPolicyFactory() override;
IRoutingPolicy::UP create(const string &param) override;
};
+RemoveReplyPolicyFactory::~RemoveReplyPolicyFactory() = default;
+
RemoveReplyPolicyFactory::RemoveReplyPolicyFactory(bool selectOnRetry,
const std::vector<uint32_t> &consumableErrors,
uint32_t idxRemove) :
@@ -233,6 +236,7 @@ private:
public:
SetReplyPolicyFactory(bool selectOnRetry,
const std::vector<uint32_t> &errors);
+ ~SetReplyPolicyFactory() override;
IRoutingPolicy::UP create(const string &param) override;
};
@@ -244,6 +248,8 @@ SetReplyPolicyFactory::SetReplyPolicyFactory(bool selectOnRetry,
// empty
}
+SetReplyPolicyFactory::~SetReplyPolicyFactory() = default;
+
IRoutingPolicy::UP
SetReplyPolicyFactory::create(const string &param)
{
@@ -270,12 +276,15 @@ public:
class SelectExceptionPolicyFactory : public SimpleProtocol::IPolicyFactory {
public:
+ ~SelectExceptionPolicyFactory() override;
IRoutingPolicy::UP create(const string &param) override {
(void)param;
return IRoutingPolicy::UP(new SelectExceptionPolicy());
}
};
+SelectExceptionPolicyFactory::~SelectExceptionPolicyFactory() = default;
+
class MergeExceptionPolicy : public IRoutingPolicy {
private:
const string _select;
@@ -299,11 +308,14 @@ public:
class MergeExceptionPolicyFactory : public SimpleProtocol::IPolicyFactory {
public:
+ ~MergeExceptionPolicyFactory() override;
IRoutingPolicy::UP create(const string &param) override {
return IRoutingPolicy::UP(new MergeExceptionPolicy(param));
}
};
+MergeExceptionPolicyFactory::~MergeExceptionPolicyFactory() = default;
+
class MyPolicyFactory : public SimpleProtocol::IPolicyFactory {
private:
string _selectRoute;
diff --git a/messagebus/src/tests/routingcontext/routingcontext.cpp b/messagebus/src/tests/routingcontext/routingcontext.cpp
index 737673a73ba..aba50156412 100644
--- a/messagebus/src/tests/routingcontext/routingcontext.cpp
+++ b/messagebus/src/tests/routingcontext/routingcontext.cpp
@@ -48,9 +48,12 @@ public:
CustomPolicyFactory(bool forward,
const std::vector<string> &all,
const std::vector<string> &matched);
+ ~CustomPolicyFactory() override;
IRoutingPolicy::UP create(const string &param) override;
};
+CustomPolicyFactory::~CustomPolicyFactory() = default;
+
class CustomPolicy : public IRoutingPolicy {
private:
CustomPolicyFactory &_factory;
diff --git a/messagebus/src/tests/sendadapter/sendadapter.cpp b/messagebus/src/tests/sendadapter/sendadapter.cpp
index b5990521128..0ae957ea340 100644
--- a/messagebus/src/tests/sendadapter/sendadapter.cpp
+++ b/messagebus/src/tests/sendadapter/sendadapter.cpp
@@ -26,6 +26,7 @@ private:
public:
typedef std::shared_ptr<TestProtocol> SP;
+ ~TestProtocol() override;
mbus::Blob encode(const vespalib::Version &version, const mbus::Routable &routable) const override {
_lastVersion = version;
return mbus::SimpleProtocol::encode(version, routable);
@@ -37,6 +38,8 @@ public:
const vespalib::Version &getLastVersion() { return _lastVersion; }
};
+TestProtocol::~TestProtocol() = default;
+
class TestData {
public:
Slobrok _slobrok;
diff --git a/messagebus/src/vespa/messagebus/routing/routingtablespec.cpp b/messagebus/src/vespa/messagebus/routing/routingtablespec.cpp
index 43b1032ce57..328565a3ef7 100644
--- a/messagebus/src/vespa/messagebus/routing/routingtablespec.cpp
+++ b/messagebus/src/vespa/messagebus/routing/routingtablespec.cpp
@@ -12,8 +12,12 @@ RoutingTableSpec::RoutingTableSpec(const string &protocol) :
_routes()
{ }
+RoutingTableSpec::RoutingTableSpec(const RoutingTableSpec&) = default;
+
RoutingTableSpec::~RoutingTableSpec() {}
+RoutingTableSpec& RoutingTableSpec::operator=(const RoutingTableSpec&) = default;
+
HopSpec
RoutingTableSpec::removeHop(uint32_t i)
{
diff --git a/messagebus/src/vespa/messagebus/routing/routingtablespec.h b/messagebus/src/vespa/messagebus/routing/routingtablespec.h
index 5886f82ae81..eb0078d1767 100644
--- a/messagebus/src/vespa/messagebus/routing/routingtablespec.h
+++ b/messagebus/src/vespa/messagebus/routing/routingtablespec.h
@@ -31,7 +31,11 @@ public:
* @param protocol The name of the protocol that this belongs to.
*/
RoutingTableSpec(const string &protocol);
+ RoutingTableSpec(const RoutingTableSpec&);
+ RoutingTableSpec(RoutingTableSpec&&) noexcept = default;
~RoutingTableSpec();
+ RoutingTableSpec &operator=(const RoutingTableSpec&);
+ RoutingTableSpec &operator=(RoutingTableSpec&&) noexcept = default;
/**
* Returns the name of the protocol that this is the routing table for.
diff --git a/messagebus/src/vespa/messagebus/testlib/simpleprotocol.cpp b/messagebus/src/vespa/messagebus/testlib/simpleprotocol.cpp
index e90cf0dd7a8..4475851e94a 100644
--- a/messagebus/src/vespa/messagebus/testlib/simpleprotocol.cpp
+++ b/messagebus/src/vespa/messagebus/testlib/simpleprotocol.cpp
@@ -30,8 +30,11 @@ public:
IRoutingPolicy::UP create(const string &) override {
return IRoutingPolicy::UP(new AllPolicy());
}
+ ~AllPolicyFactory() override;
};
+AllPolicyFactory::~AllPolicyFactory() = default;
+
class HashPolicy : public IRoutingPolicy {
public:
void select(RoutingContext &ctx) override {
@@ -53,8 +56,11 @@ public:
IRoutingPolicy::UP create(const string &) override {
return IRoutingPolicy::UP(new HashPolicy());
}
+ ~HashPolicyFactory() override;
};
+HashPolicyFactory::~HashPolicyFactory() = default;
+
SimpleProtocol::SimpleProtocol() :
_policies()
{