summaryrefslogtreecommitdiffstats
path: root/messagebus
diff options
context:
space:
mode:
authorJon Marius Venstad <venstad@gmail.com>2020-12-02 15:09:01 +0100
committerJon Marius Venstad <venstad@gmail.com>2020-12-02 15:09:01 +0100
commit2461523aca39b5af3b5bafef44e51c7bb13be76b (patch)
tree472685b642f55a5eef63651f51928331875d2867 /messagebus
parentb38ce2dd957fa3fd4ddd86a7564a4cd095fdb06f (diff)
Fix parentheses in carry expression
Diffstat (limited to 'messagebus')
-rw-r--r--messagebus/src/main/java/com/yahoo/messagebus/DynamicThrottlePolicy.java5
1 files changed, 3 insertions, 2 deletions
diff --git a/messagebus/src/main/java/com/yahoo/messagebus/DynamicThrottlePolicy.java b/messagebus/src/main/java/com/yahoo/messagebus/DynamicThrottlePolicy.java
index 93c63112b46..514f1234e89 100644
--- a/messagebus/src/main/java/com/yahoo/messagebus/DynamicThrottlePolicy.java
+++ b/messagebus/src/main/java/com/yahoo/messagebus/DynamicThrottlePolicy.java
@@ -23,7 +23,7 @@ public class DynamicThrottlePolicy extends StaticThrottlePolicy {
private double resizeRate = 3;
private long resizeTime = 0;
private long timeOfLastMessage;
- private double efficiencyThreshold = 1.0;
+ private double efficiencyThreshold = 1;
private double windowSizeIncrement = 20;
private double windowSize = windowSizeIncrement;
private double minWindowSize = windowSizeIncrement;
@@ -77,7 +77,8 @@ public class DynamicThrottlePolicy extends StaticThrottlePolicy {
}
timeOfLastMessage = time;
int windowSizeFloored = (int) windowSize;
- boolean carry = numSent < (windowSize * resizeRate) * windowSize - windowSizeFloored;
+ // Use floating point window sizes, so the algorithm sees the different in 1.1 and 1.9 window size.
+ boolean carry = numSent < (windowSize * resizeRate) * (windowSize - windowSizeFloored);
return pendingCount < windowSizeFloored + (carry ? 1 : 0);
}