- No need for final on locals and params.

- Log with lambda to avoid explicit guard.
- Log old localMaxThroughput, not new value twice.

1 files changed, 3 insertions, 7 deletions

diff --git a/messagebus/src/main/java/com/yahoo/messagebus/DynamicThrottlePolicy.java b/messagebus/src/main/java/com/yahoo/messagebus/DynamicThrottlePolicy.java
index 76287d949b7..97f681404e9 100644
--- a/messagebus/src/main/java/com/yahoo/messagebus/DynamicThrottlePolicy.java
+++ b/messagebus/src/main/java/com/yahoo/messagebus/DynamicThrottlePolicy.java
@@ -133,11 +133,9 @@ public class DynamicThrottlePolicy extends StaticThrottlePolicy {
             // No need to increase window when we're this close to max.
             // TODO jonmv: Not so sure — what if we're too high, and should back off?
         } else if (throughput > localMaxThroughput) {
-            localMaxThroughput = throughput;
             windowSize += weight * windowSizeIncrement;
-            if (log.isLoggable(Level.FINE)) {
-                log.log(Level.FINE, "windowSize " + windowSize + " throughput " + throughput + " local max " + localMaxThroughput);
-            }
+            log.log(Level.FINE, () -> "windowSize " + windowSize + " throughput " + throughput + " local max " + localMaxThroughput);
+            localMaxThroughput = throughput;
         } else {
             // scale up/down throughput for comparing to window size
             double period = 1;
@@ -154,9 +152,7 @@ public class DynamicThrottlePolicy extends StaticThrottlePolicy {
             } else {
                 windowSize += weight * windowSizeIncrement;
             }
-            if (log.isLoggable(Level.FINE)) {
-                log.log(Level.FINE, "windowSize " + windowSize + " throughput " + throughput + " local max " + localMaxThroughput + " efficiency " + efficiency);
-            }
+            log.log(Level.FINE, () ->"windowSize " + windowSize + " throughput " + throughput + " local max " + localMaxThroughput + " efficiency " + efficiency);
         }
         windowSize = Math.max(minWindowSize, windowSize);
         windowSize = Math.min(maxWindowSize, windowSize);