summaryrefslogtreecommitdiffstats
path: root/metrics-proxy/src/test
diff options
context:
space:
mode:
authorgjoranv <gv@verizonmedia.com>2020-01-09 14:52:26 +0100
committergjoranv <gv@verizonmedia.com>2020-01-09 14:54:47 +0100
commit9634c697290c3df7d031608eaaeea2b7783168b5 (patch)
tree976591e1eb70f2e944d68e0efde7c928adb83807 /metrics-proxy/src/test
parent9a16e95693f9c2c15bbe8ace8e4f4b264fe508ef (diff)
Move node name out of the 'node' object.
- The 'node' object is for node metrics, so it makes more sense to have the node name as a sibling to 'node' and 'services'.
Diffstat (limited to 'metrics-proxy/src/test')
-rw-r--r--metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/application/ApplicationMetricsHandlerTest.java2
-rw-r--r--metrics-proxy/src/test/java/ai/vespa/metricsproxy/metric/model/json/GenericApplicationModelTest.java6
-rw-r--r--metrics-proxy/src/test/resources/generic-application.json4
3 files changed, 6 insertions, 6 deletions
diff --git a/metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/application/ApplicationMetricsHandlerTest.java b/metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/application/ApplicationMetricsHandlerTest.java
index 2d12930bd0a..d1224e79e45 100644
--- a/metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/application/ApplicationMetricsHandlerTest.java
+++ b/metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/application/ApplicationMetricsHandlerTest.java
@@ -117,7 +117,7 @@ public class ApplicationMetricsHandlerTest {
assertEquals(1, jsonModel.nodes.size());
GenericJsonModel nodeModel = jsonModel.nodes.get(0);
- assertEquals(MOCK_METRICS_PATH, nodeModel.node.name);
+ assertEquals(MOCK_METRICS_PATH, nodeModel.name);
assertEquals(2, nodeModel.node.metrics.size());
assertEquals(16.222, nodeModel.node.metrics.get(0).values.get(CPU_METRIC), 0.0001d);
}
diff --git a/metrics-proxy/src/test/java/ai/vespa/metricsproxy/metric/model/json/GenericApplicationModelTest.java b/metrics-proxy/src/test/java/ai/vespa/metricsproxy/metric/model/json/GenericApplicationModelTest.java
index 47d91fb57a3..c0abc3efb86 100644
--- a/metrics-proxy/src/test/java/ai/vespa/metricsproxy/metric/model/json/GenericApplicationModelTest.java
+++ b/metrics-proxy/src/test/java/ai/vespa/metricsproxy/metric/model/json/GenericApplicationModelTest.java
@@ -33,7 +33,7 @@ public class GenericApplicationModelTest {
// Do some sanity checking
assertEquals(2, model.nodes.size());
GenericJsonModel node0Model = model.nodes.get(0);
- assertEquals("node0", node0Model.node.name);
+ assertEquals("node0", node0Model.name);
assertEquals(1, node0Model.services.size());
GenericService service = node0Model.services.get(0);
assertEquals(1, service.metrics.size());
@@ -41,7 +41,7 @@ public class GenericApplicationModelTest {
GenericJsonModel node1Model = model.nodes.get(1);
GenericNode node1 = node1Model.node;
- assertEquals("node1", node1.name);
+ assertEquals("node1", node1Model.name);
assertEquals(32.444, node1.metrics.get(0).values.get("cpu.util"), 0.001d);
assertThatSerializedModelEqualsTestFile(model);
@@ -69,7 +69,7 @@ public class GenericApplicationModelTest {
GenericJsonModel nodeModel = model.nodes.get(0);
assertNotNull(nodeModel.node);
- assertEquals("node0", nodeModel.node.name);
+ assertEquals("node0", nodeModel.name);
assertEquals(1, nodeModel.node.metrics.size());
GenericMetrics nodeMetrics = nodeModel.node.metrics.get(0);
assertEquals(1.234, nodeMetrics.values.get("node-metric"), 0.001d);
diff --git a/metrics-proxy/src/test/resources/generic-application.json b/metrics-proxy/src/test/resources/generic-application.json
index 231f86a9b3b..5ddd11962be 100644
--- a/metrics-proxy/src/test/resources/generic-application.json
+++ b/metrics-proxy/src/test/resources/generic-application.json
@@ -1,8 +1,8 @@
{
"nodes": [
{
+ "name": "node0",
"node": {
- "name": "node0",
"timestamp": 1234,
"metrics": [
{
@@ -36,8 +36,8 @@
]
},
{
+ "name": "node1",
"node": {
- "name": "node1",
"timestamp": 1234,
"metrics": [
{