summaryrefslogtreecommitdiffstats
path: root/metrics-proxy/src/test
diff options
context:
space:
mode:
authorgjoranv <gv@verizonmedia.com>2022-09-26 22:30:14 +0200
committergjoranv <gv@verizonmedia.com>2022-09-26 22:30:14 +0200
commite4507a9e813e0eab970422a2f4df0c4c60a5e5e1 (patch)
tree2abb858e943efec60f39e374d05e6df29af75522 /metrics-proxy/src/test
parentbbc79e913fce52a52c76c3427d5d655e59955acf (diff)
Ignore case when looking up metrics consumer.
Diffstat (limited to 'metrics-proxy/src/test')
-rw-r--r--metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/metrics/MetricsHandlerTestBase.java11
1 files changed, 11 insertions, 0 deletions
diff --git a/metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/metrics/MetricsHandlerTestBase.java b/metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/metrics/MetricsHandlerTestBase.java
index 1c6a09c3ee0..b6521a89ce7 100644
--- a/metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/metrics/MetricsHandlerTestBase.java
+++ b/metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/metrics/MetricsHandlerTestBase.java
@@ -13,6 +13,7 @@ import org.junit.Ignore;
import org.junit.Test;
import java.io.IOException;
+import java.util.Locale;
import static ai.vespa.metricsproxy.metric.dimensions.PublicDimensions.INTERNAL_SERVICE_ID;
import static ai.vespa.metricsproxy.metric.dimensions.PublicDimensions.REASON;
@@ -151,6 +152,16 @@ public abstract class MetricsHandlerTestBase<MODEL> extends HttpHandlerTestBase
assertEquals("custom-val", dummy1Metrics.dimensions.get(REASON));
}
+ @Test
+ public void consumer_name_is_case_insensitive() {
+ GenericJsonModel jsonModel = getResponseAsGenericJsonModel(CUSTOM_CONSUMER.toUpperCase(Locale.ROOT));
+ GenericService dummyService = jsonModel.services.get(0);
+ GenericMetrics dummy0Metrics = getMetricsForService("dummy0", dummyService);
+
+ // If name was case-sensitive, this would be the default value.
+ assertEquals("custom-val", dummy0Metrics.dimensions.get(REASON));
+ }
+
private static GenericMetrics getMetricsForService(String serviceInstance, GenericService service) {
for (var metrics : service.metrics) {
if (getServiceIdDimension(metrics).equals(serviceInstance))