aboutsummaryrefslogtreecommitdiffstats
path: root/metrics-proxy/src
diff options
context:
space:
mode:
authorgjoranv <gv@verizonmedia.com>2019-08-26 12:00:10 +0200
committergjoranv <gv@verizonmedia.com>2019-08-26 12:00:53 +0200
commit6c0ed461c65bbaa90a208049031e9eef33fe6c6a (patch)
tree1152d1b3d251a113e12cf97a1e460ebc60f940e0 /metrics-proxy/src
parentec4240010b82eabc1fa0efad47082541da9d246a (diff)
Add missing test for invalid path
Diffstat (limited to 'metrics-proxy/src')
-rw-r--r--metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/MetricsHandlerTest.java9
1 files changed, 8 insertions, 1 deletions
diff --git a/metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/MetricsHandlerTest.java b/metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/MetricsHandlerTest.java
index 66220464e3e..ab0c6c7e6a6 100644
--- a/metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/MetricsHandlerTest.java
+++ b/metrics-proxy/src/test/java/ai/vespa/metricsproxy/http/MetricsHandlerTest.java
@@ -113,7 +113,7 @@ public class MetricsHandlerTest {
@Ignore
@Test
- public void visually_inspect_values_response() throws Exception{
+ public void visually_inspect_values_response() throws Exception {
String response = testDriver.sendRequest(VALUES_URI).readAll();
ObjectMapper mapper = createObjectMapper();
var jsonModel = mapper.readValue(response, GenericJsonModel.class);
@@ -199,6 +199,13 @@ public class MetricsHandlerTest {
assertEquals("custom-val", dummy1Metrics.dimensions.get("consumer-dim"));
}
+ @Test
+ public void invalid_path_yields_error_response() throws Exception {
+ String response = testDriver.sendRequest(V1_URI + "/invalid").readAll();
+ JSONObject root = new JSONObject(response);
+ assertTrue(root.has("error"));
+ }
+
private void assertDownServiceHealth(String consumer) {
GenericJsonModel jsonModel = getResponseAsJsonModel(consumer);