summaryrefslogtreecommitdiffstats
path: root/metrics-proxy
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2022-12-16 17:06:17 +0100
committerHenning Baldersheim <balder@yahoo-inc.com>2022-12-16 17:06:17 +0100
commit64f178a21c1db6a75bf3b5a738e54d06314a97d7 (patch)
tree7b879e9e0119460e3d2a117a0ec1b4bb050452ce /metrics-proxy
parentbded305a9d33e5ba66f1f7b34f267e4b0e112d79 (diff)
Add unit test showing that we are not there yet.
Diffstat (limited to 'metrics-proxy')
-rw-r--r--metrics-proxy/src/test/java/ai/vespa/metricsproxy/service/MetricsParserTest.java16
1 files changed, 14 insertions, 2 deletions
diff --git a/metrics-proxy/src/test/java/ai/vespa/metricsproxy/service/MetricsParserTest.java b/metrics-proxy/src/test/java/ai/vespa/metricsproxy/service/MetricsParserTest.java
index 659305a8543..5fc260e9912 100644
--- a/metrics-proxy/src/test/java/ai/vespa/metricsproxy/service/MetricsParserTest.java
+++ b/metrics-proxy/src/test/java/ai/vespa/metricsproxy/service/MetricsParserTest.java
@@ -34,12 +34,24 @@ public class MetricsParserTest {
new MetricsParser.Dimension("cluster", "CLUSTER-2"),
new MetricsParser.Dimension("clusterid", "CLUSTER-2"));
- System.out.println(dimensionsHashCode(dimensions1));
- System.out.println(dimensionsHashCode(dimensions2));
assertNotEquals(dimensionsHashCode(dimensions1), dimensionsHashCode(dimensions2));
}
@Test
+ public void dimensions_hashcode_is_different_for_distinct_with_swapped_dimension_values() {
+ var dimensions1 = List.of(
+ new MetricsParser.Dimension("cluster", "CLUSTER-1"),
+ new MetricsParser.Dimension("clusterid", "CLUSTER-2"));
+
+ var dimensions2 = List.of(
+ new MetricsParser.Dimension("cluster", "CLUSTER-2"),
+ new MetricsParser.Dimension("clusterid", "CLUSTER-1"));
+
+ assertNotEquals(dimensionsHashCode(dimensions1), dimensionsHashCode(dimensions2));
+ }
+
+
+ @Test
public void different_dimension_values_are_not_treated_as_equal() throws Exception {
var collector = new MetricsCollector();
MetricsParser.parse(metricsJson(), collector);