summaryrefslogtreecommitdiffstats
path: root/metrics-proxy
diff options
context:
space:
mode:
authorgjoranv <gv@verizonmedia.com>2019-05-29 21:48:10 +0200
committergjoranv <gv@verizonmedia.com>2019-05-29 21:48:10 +0200
commit4c670fa4c537b1182bfeb6ccf85ce06f8fedf858 (patch)
treeb81ed2c21dfcd0cdecd32a199da39f4cd51e2e78 /metrics-proxy
parent5580ff82ed14ba1ea19163d9274371e9689f45e7 (diff)
Minor non-functional improvements.
Diffstat (limited to 'metrics-proxy')
-rw-r--r--metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/ConfigSentinelClient.java3
-rw-r--r--metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/SystemPoller.java4
2 files changed, 3 insertions, 4 deletions
diff --git a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/ConfigSentinelClient.java b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/ConfigSentinelClient.java
index 875b6190763..604d020252f 100644
--- a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/ConfigSentinelClient.java
+++ b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/ConfigSentinelClient.java
@@ -47,7 +47,7 @@ public class ConfigSentinelClient {
*
* @param s The service to update the status for
*/
- public synchronized void ping(VespaService s) {
+ synchronized void ping(VespaService s) {
List<VespaService> services = new ArrayList<>();
services.add(s);
log.log(LogLevel.DEBUG, "Ping for service " + s);
@@ -66,7 +66,6 @@ public class ConfigSentinelClient {
*/
protected synchronized void setStatus(List<VespaService> services) throws Exception {
InputStream in;
- PrintStream out;
client.connect();
in = client.getInputStream();
diff --git a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/SystemPoller.java b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/SystemPoller.java
index 9f6614668a5..e19d65f2838 100644
--- a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/SystemPoller.java
+++ b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/SystemPoller.java
@@ -27,7 +27,7 @@ import java.util.logging.Logger;
* @author Eirik Nygaard
*/
public class SystemPoller implements ServiceListener {
- final private static Logger log = Logger.getLogger(SystemPoller.class.getPackage().getName());
+ final private static Logger log = Logger.getLogger(SystemPoller.class.getName());
private final int pollingIntervalSecs;
private volatile List<VespaService> services;
@@ -169,7 +169,7 @@ public class SystemPoller implements ServiceListener {
try {
in = new BufferedReader(new FileReader("/proc/" + pid + "/stat"));
} catch (FileNotFoundException ex) {
- log.log(LogLevel.DEBUG, "Unable to find pid in proc directory " + pid);
+ log.log(LogLevel.DEBUG, "Unable to find pid " + pid + " in proc directory, for service " + service.getInstanceName());
service.setAlive(false);
return 0;
}