diff options
| author | gjoranv <gv@verizonmedia.com> | 2019-06-22 21:53:23 +0200 |
|---|---|---|
| committer | gjoranv <gv@verizonmedia.com> | 2019-06-22 22:13:27 +0200 |
| commit | 599758db44847200f2789e5d2e66ec85d6f528b6 (patch) | |
| tree | ab749335e441c0956b7751e48f6500ec41286241 /metrics-proxy | |
| parent | c503629050eac03b7ed55d6ad3c1267da6e1e565 (diff) | |
Add TODOs for filtering of extra (node) metrics.
Diffstat (limited to 'metrics-proxy')
| -rw-r--r-- | metrics-proxy/src/main/java/ai/vespa/metricsproxy/metric/ExternalMetrics.java | 2 | ||||
| -rw-r--r-- | metrics-proxy/src/test/java/ai/vespa/metricsproxy/core/MetricsManagerTest.java | 1 |
2 files changed, 3 insertions, 0 deletions
diff --git a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/metric/ExternalMetrics.java b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/metric/ExternalMetrics.java index 26ae177d767..64ede137e8e 100644 --- a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/metric/ExternalMetrics.java +++ b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/metric/ExternalMetrics.java @@ -53,6 +53,8 @@ public class ExternalMetrics { } public void setExtraMetrics(List<MetricsPacket.Builder> externalPackets) { + // TODO: Metrics filtering per consumer is not yet implemented. + // Split each packet per metric, and re-aggregate based on the metrics each consumer wants. Then filter out all packages with no consumers. log.log(DEBUG, () -> "Setting new external metrics with " + externalPackets.size() + " metrics packets."); externalPackets.forEach(packet -> { packet.addConsumers(consumers.getAllConsumers()) diff --git a/metrics-proxy/src/test/java/ai/vespa/metricsproxy/core/MetricsManagerTest.java b/metrics-proxy/src/test/java/ai/vespa/metricsproxy/core/MetricsManagerTest.java index eb620fd37be..e441c353292 100644 --- a/metrics-proxy/src/test/java/ai/vespa/metricsproxy/core/MetricsManagerTest.java +++ b/metrics-proxy/src/test/java/ai/vespa/metricsproxy/core/MetricsManagerTest.java @@ -140,6 +140,7 @@ public class MetricsManagerTest { service0.setSystemMetrics(oldSystemMetrics); } + // TODO: test that non-whitelisted metrics are filtered out, but this is currently not the case, see ExternalMetrics.setExtraMetrics @Test public void extra_metrics_packets_containing_whitelisted_metrics_are_added() { metricsManager.setExtraMetrics(ImmutableList.of( |