summaryrefslogtreecommitdiffstats
path: root/metrics
diff options
context:
space:
mode:
authoryngveaasheim <yngve@yahooinc.com>2023-09-12 16:41:22 +0200
committeryngveaasheim <yngve@yahooinc.com>2023-09-12 16:41:22 +0200
commit275a418deeb06ed6124719751921a22cd98f9ddc (patch)
treea502cec89204d928e47a2645f25e95c028dd5366 /metrics
parentb64893b7a0c53ff0a246177fb4062b11e0d39cba (diff)
Avoid suffix .last
Diffstat (limited to 'metrics')
-rw-r--r--metrics/src/main/java/ai/vespa/metrics/set/Vespa9DefaultMetricSet.java5
-rw-r--r--metrics/src/main/java/ai/vespa/metrics/set/Vespa9VespaMetricSet.java5
2 files changed, 4 insertions, 6 deletions
diff --git a/metrics/src/main/java/ai/vespa/metrics/set/Vespa9DefaultMetricSet.java b/metrics/src/main/java/ai/vespa/metrics/set/Vespa9DefaultMetricSet.java
index a87557981b7..556f965f0ca 100644
--- a/metrics/src/main/java/ai/vespa/metrics/set/Vespa9DefaultMetricSet.java
+++ b/metrics/src/main/java/ai/vespa/metrics/set/Vespa9DefaultMetricSet.java
@@ -17,7 +17,6 @@ import java.util.List;
import static ai.vespa.metrics.Suffix.average;
import static ai.vespa.metrics.Suffix.count;
-import static ai.vespa.metrics.Suffix.last;
import static ai.vespa.metrics.Suffix.max;
import static ai.vespa.metrics.Suffix.min;
import static ai.vespa.metrics.Suffix.ninety_five_percentile;
@@ -74,7 +73,7 @@ public class Vespa9DefaultMetricSet {
.metric(ContainerMetrics.JDISC_HTTP_SSL_HANDSHAKE_FAILURE_INCOMPATIBLE_CHIFERS.rate())
.metric(ContainerMetrics.JDISC_HTTP_SSL_HANDSHAKE_FAILURE_UNKNOWN.rate())
.metric(ContainerMetrics.JDISC_APPLICATION_FAILED_COMPONENT_GRAPHS.rate())
- .metric(ContainerMetrics.ATHENZ_TENANT_CERT_EXPIRY_SECONDS, EnumSet.of(min, max, last)) // TODO: Vespa 9: Remove max, last
+ .metric(ContainerMetrics.ATHENZ_TENANT_CERT_EXPIRY_SECONDS.min())
.build();
}
@@ -147,7 +146,7 @@ public class Vespa9DefaultMetricSet {
return new MetricSet.Builder("default-cluster-controller")
.metric(ClusterControllerMetrics.DOWN_COUNT.max())
.metric(ClusterControllerMetrics.MAINTENANCE_COUNT.max())
- .metric(ClusterControllerMetrics.UP_COUNT, EnumSet.of(max, last)) // TODO: Remove last
+ .metric(ClusterControllerMetrics.UP_COUNT.max())
.metric(ClusterControllerMetrics.IS_MASTER.max())
.metric(ClusterControllerMetrics.RESOURCE_USAGE_NODES_ABOVE_LIMIT.max())
.metric(ClusterControllerMetrics.RESOURCE_USAGE_MAX_MEMORY_UTILIZATION.max())
diff --git a/metrics/src/main/java/ai/vespa/metrics/set/Vespa9VespaMetricSet.java b/metrics/src/main/java/ai/vespa/metrics/set/Vespa9VespaMetricSet.java
index 19e27162d74..47cbc869d90 100644
--- a/metrics/src/main/java/ai/vespa/metrics/set/Vespa9VespaMetricSet.java
+++ b/metrics/src/main/java/ai/vespa/metrics/set/Vespa9VespaMetricSet.java
@@ -25,7 +25,6 @@ import java.util.Set;
import static ai.vespa.metrics.Suffix.average;
import static ai.vespa.metrics.Suffix.count;
-import static ai.vespa.metrics.Suffix.last;
import static ai.vespa.metrics.Suffix.max;
import static ai.vespa.metrics.Suffix.min;
import static ai.vespa.metrics.Suffix.ninety_five_percentile;
@@ -181,7 +180,7 @@ public class Vespa9VespaMetricSet {
addMetric(metrics, ContainerMetrics.JDISC_SINGLETON_IS_ACTIVE.max());
- addMetric(metrics, ContainerMetrics.ATHENZ_TENANT_CERT_EXPIRY_SECONDS, EnumSet.of(min, max, last)); // TODO: Vespa 9: Remove max, last
+ addMetric(metrics, ContainerMetrics.ATHENZ_TENANT_CERT_EXPIRY_SECONDS.min());
addMetric(metrics, ContainerMetrics.CONTAINER_IAM_ROLE_EXPIRY_SECONDS.baseName());
addMetric(metrics, ContainerMetrics.JDISC_HTTP_REQUEST_PREMATURELY_CLOSED.rate());
@@ -226,7 +225,7 @@ public class Vespa9VespaMetricSet {
addMetric(metrics, ClusterControllerMetrics.INITIALIZING_COUNT.max());
addMetric(metrics, ClusterControllerMetrics.MAINTENANCE_COUNT.max());
addMetric(metrics, ClusterControllerMetrics.RETIRED_COUNT.max());
- addMetric(metrics, ClusterControllerMetrics.UP_COUNT, EnumSet.of(max, last)); // TODO: Remove last
+ addMetric(metrics, ClusterControllerMetrics.UP_COUNT.max());
addMetric(metrics, ClusterControllerMetrics.CLUSTER_STATE_CHANGE_COUNT.baseName());
addMetric(metrics, ClusterControllerMetrics.BUSY_TICK_TIME_MS, EnumSet.of(max, sum, count));
addMetric(metrics, ClusterControllerMetrics.IDLE_TICK_TIME_MS, EnumSet.of(max, sum, count));