summaryrefslogtreecommitdiffstats
path: root/model-evaluation/src/test
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2022-12-01 22:45:55 +0100
committerHenning Baldersheim <balder@yahoo-inc.com>2022-12-01 22:45:55 +0100
commit6a9681d7f3e42f29bd1d9de9fe9c271489b0c886 (patch)
tree227e5c3f2e1fcae248e0daf85735358b06971e33 /model-evaluation/src/test
parent1eb22cc4a24973f52b344c3033cff394c724cbe4 (diff)
Use well defined order where we output text and generate config. Makes config stable and simple tests predictable.
Diffstat (limited to 'model-evaluation/src/test')
-rw-r--r--model-evaluation/src/test/java/ai/vespa/models/evaluation/MlModelsImportingTest.java12
-rw-r--r--model-evaluation/src/test/java/ai/vespa/models/evaluation/ModelsEvaluatorTest.java2
2 files changed, 7 insertions, 7 deletions
diff --git a/model-evaluation/src/test/java/ai/vespa/models/evaluation/MlModelsImportingTest.java b/model-evaluation/src/test/java/ai/vespa/models/evaluation/MlModelsImportingTest.java
index 6a66202609b..d76bade6c1a 100644
--- a/model-evaluation/src/test/java/ai/vespa/models/evaluation/MlModelsImportingTest.java
+++ b/model-evaluation/src/test/java/ai/vespa/models/evaluation/MlModelsImportingTest.java
@@ -38,7 +38,7 @@ public class MlModelsImportingTest {
xgboost);
assertEquals("tensor()", function.returnType().get().toString());
assertEquals("f109, f29, f56, f60", commaSeparated(function.arguments()));
- function.arguments().forEach(arg -> assertEquals(TensorType.empty, function.argumentTypes().get(arg)));
+ function.arguments().forEach(arg -> assertEquals(TensorType.empty, function.getArgumentType(arg)));
// Evaluator
FunctionEvaluator evaluator = xgboost.evaluatorOf();
@@ -56,7 +56,7 @@ public class MlModelsImportingTest {
lightgbm);
assertEquals("tensor()", function.returnType().get().toString());
assertEquals("categorical_1, categorical_2, numerical_1, numerical_2", commaSeparated(function.arguments()));
- function.arguments().forEach(arg -> assertEquals(TensorType.empty, function.argumentTypes().get(arg)));
+ function.arguments().forEach(arg -> assertEquals(TensorType.empty, function.getArgumentType(arg)));
// Evaluator
FunctionEvaluator evaluator = lightgbm.evaluatorOf();
@@ -76,7 +76,7 @@ public class MlModelsImportingTest {
assertEquals("tensor(d1[10])", function.returnType().get().toString());
assertEquals(1, function.arguments().size());
assertEquals("Placeholder", function.arguments().get(0));
- assertEquals("tensor(d0[],d1[784])", function.argumentTypes().get("Placeholder").toString());
+ assertEquals("tensor(d0[],d1[784])", function.getArgumentType("Placeholder").toString());
// Evaluator
assertEquals("tensor(d1[10],d2[784])",
@@ -98,7 +98,7 @@ public class MlModelsImportingTest {
assertEquals("tensor(d1[10])", function.returnType().get().toString());
assertEquals(1, function.arguments().size());
assertEquals("Placeholder", function.arguments().get(0));
- assertEquals("tensor(d0[],d1[784])", function.argumentTypes().get("Placeholder").toString());
+ assertEquals("tensor(d0[],d1[784])", function.getArgumentType("Placeholder").toString());
// Evaluator
FunctionEvaluator evaluator = tfMnistSoftmax.evaluatorOf(); // Verify exactly one output available
@@ -116,7 +116,7 @@ public class MlModelsImportingTest {
assertEquals("tensor(d3[300])", generatedFunction.returnType().get().toString());
assertEquals(1, generatedFunction.arguments().size());
assertEquals("input", generatedFunction.arguments().get(0));
- assertNull(null, generatedFunction.argumentTypes().get("input")); // TODO: Not available until we resolve all argument types
+ assertNull(null, generatedFunction.getArgumentType("input")); // TODO: Not available until we resolve all argument types
// Function
assertEquals(1, tfMnist.functions().size());
@@ -127,7 +127,7 @@ public class MlModelsImportingTest {
assertEquals("tensor(d1[10])", function.returnType().get().toString());
assertEquals(1, function.arguments().size());
assertEquals("input", function.arguments().get(0));
- assertEquals("tensor(d0[],d1[784])", function.argumentTypes().get("input").toString());
+ assertEquals("tensor(d0[],d1[784])", function.getArgumentType("input").toString());
// Evaluator
FunctionEvaluator evaluator = tfMnist.evaluatorOf("serving_default");
diff --git a/model-evaluation/src/test/java/ai/vespa/models/evaluation/ModelsEvaluatorTest.java b/model-evaluation/src/test/java/ai/vespa/models/evaluation/ModelsEvaluatorTest.java
index f09bac63085..3cd04db8edd 100644
--- a/model-evaluation/src/test/java/ai/vespa/models/evaluation/ModelsEvaluatorTest.java
+++ b/model-evaluation/src/test/java/ai/vespa/models/evaluation/ModelsEvaluatorTest.java
@@ -104,7 +104,7 @@ public class ModelsEvaluatorTest {
evaluator.evaluate();
}
catch (IllegalArgumentException e) {
- assertEquals("'argNone' is not a valid argument in function 'test'. Expected arguments: arg2: tensor(d1{}), arg1: tensor(d0[1])",
+ assertEquals("'argNone' is not a valid argument in function 'test'. Expected arguments: arg1: tensor(d0[1]), arg2: tensor(d1{})",
Exceptions.toMessageString(e));
}