diff options
| author | Lester Solbakken <lesters@oath.com> | 2019-09-24 12:42:43 +0200 |
|---|---|---|
| committer | Lester Solbakken <lesters@oath.com> | 2019-09-24 12:42:43 +0200 |
| commit | e44a0e7e2e662a3c82fcd6852a05523321e4ca93 (patch) | |
| tree | 1b06ab29bf6f415fdcd47f8580782f98fd41ba7b /model-integration | |
| parent | e1723e3e7c40997ecc099ab0ccfd4f6b8ba3e221 (diff) | |
Don't call lazyGetType in toString - it can have side effects
Diffstat (limited to 'model-integration')
4 files changed, 4 insertions, 4 deletions
diff --git a/model-integration/src/main/java/ai/vespa/rankingexpression/importer/operations/Argument.java b/model-integration/src/main/java/ai/vespa/rankingexpression/importer/operations/Argument.java index 9f62a27a3b9..dad4508bc61 100644 --- a/model-integration/src/main/java/ai/vespa/rankingexpression/importer/operations/Argument.java +++ b/model-integration/src/main/java/ai/vespa/rankingexpression/importer/operations/Argument.java @@ -67,7 +67,7 @@ public class Argument extends IntermediateOperation { @Override public String toFullString() { - return "\t" + lazyGetType() + ":\tArgument(" + standardNamingType + ")"; + return "\t" + type + ":\tArgument(" + standardNamingType + ")"; } } diff --git a/model-integration/src/main/java/ai/vespa/rankingexpression/importer/operations/Const.java b/model-integration/src/main/java/ai/vespa/rankingexpression/importer/operations/Const.java index fc59ad35ef8..b092b292627 100644 --- a/model-integration/src/main/java/ai/vespa/rankingexpression/importer/operations/Const.java +++ b/model-integration/src/main/java/ai/vespa/rankingexpression/importer/operations/Const.java @@ -110,7 +110,7 @@ public class Const extends IntermediateOperation { @Override public String toFullString() { - return "\t" + lazyGetType() + ":\tConst(" + type + ")"; + return "\t" + type + ":\tConst(" + getConstantValue().get() + ")"; } } diff --git a/model-integration/src/main/java/ai/vespa/rankingexpression/importer/operations/Constant.java b/model-integration/src/main/java/ai/vespa/rankingexpression/importer/operations/Constant.java index 1eaaf705220..ad56eefe5f2 100644 --- a/model-integration/src/main/java/ai/vespa/rankingexpression/importer/operations/Constant.java +++ b/model-integration/src/main/java/ai/vespa/rankingexpression/importer/operations/Constant.java @@ -74,7 +74,7 @@ public class Constant extends IntermediateOperation { @Override public String toFullString() { - return "\t" + lazyGetType() + ":\tConstant(" + type + ")"; + return "\t" + type + ":\tConstant(" + type + ")"; } } diff --git a/model-integration/src/main/java/ai/vespa/rankingexpression/importer/operations/IntermediateOperation.java b/model-integration/src/main/java/ai/vespa/rankingexpression/importer/operations/IntermediateOperation.java index 9c9fed89585..26b376cce1c 100644 --- a/model-integration/src/main/java/ai/vespa/rankingexpression/importer/operations/IntermediateOperation.java +++ b/model-integration/src/main/java/ai/vespa/rankingexpression/importer/operations/IntermediateOperation.java @@ -226,7 +226,7 @@ public abstract class IntermediateOperation { } public String toFullString() { - return "\t" + lazyGetType() + ":\t" + operationName() + "(" + + return "\t" + type + ":\t" + operationName() + "(" + inputs().stream().map(input -> input.toFullString()).collect(Collectors.joining(", ")) + ")"; } |